You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org> on 2019/11/07 22:49:46 UTC
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile
Xiaomeng Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14660
Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile
......................................................................
IMPALA-9090 Add name of table being scanned in HDFS scan node profile
Before this change, the only way to figure out the table being scanned
by a scan node in the profile is to pull the string out of the explain
plan or execsummary. This is awkward, both for manual and automated
analysis of the profiles. We should include the table name as a string
in the SCAN_NODE implementation.
After this change, a new line "Table Name: database.table" will be added
between line HDFS_SCAN_NODE (id=0) and Hdfs split stats.
Manually tested on mini-cluster with hdfs and s3 with file format text
and parquet. All have Table Name in HDFS scan node profile.
Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
---
M be/src/exec/hdfs-scan-node-base.cc
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/14660/1
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9090: Add name of table being scanned in scan node profile
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090: Add name of table being scanned in scan node profile
......................................................................
IMPALA-9090: Add name of table being scanned in scan node profile
Before this change, the only way to figure out the table being scanned
by a scan node in the profile is to pull the string out of the explain
plan or execsummary. This is awkward, both for manual and automated
analysis of the profiles. We should include the table name as a string
in the SCAN_NODE implementation.
After this change, a new line "Table Name: database.table" will be added
in first line of scan node profile.
Also fix a bug that frontend pass hbase and kudu table name incorrectly
to thrift. Before this change, native name of hbase and kudu table are
passed in and there is no way to get hms table name from TableDescriptor
in backend.
After this change, for HBaseTableDescriptor and KuduTableDescriptor,
function name() would return hms table name, function table_name()
would return hbase or kudu native table name.
Manually tested on mini-cluster with:
1. hdfs and s3 table with file format text and parquet.
2. hbase table.
3. kudu table.
Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
---
M be/src/exec/hbase-scan-node.cc
M be/src/exec/hbase-table-writer.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/kudu-scan-node-base.cc
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
6 files changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/14660/4
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9090: Add name of table being scanned in scan node profile
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090: Add name of table being scanned in scan node profile
......................................................................
Patch Set 4: Code-Review+2
Thank you! Looks good.
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 16:59:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090: Add name of table being scanned in scan node profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090: Add name of table being scanned in scan node profile
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5254/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 16:59:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4977/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Nov 2019 23:34:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090: Add name of table being scanned in scan node profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090: Add name of table being scanned in scan node profile
......................................................................
IMPALA-9090: Add name of table being scanned in scan node profile
Before this change, the only way to figure out the table being scanned
by a scan node in the profile is to pull the string out of the explain
plan or execsummary. This is awkward, both for manual and automated
analysis of the profiles. We should include the table name as a string
in the SCAN_NODE implementation.
After this change, a new line "Table Name: database.table" will be added
in first line of scan node profile.
Also fix a bug that frontend pass hbase and kudu table name incorrectly
to thrift. Before this change, native name of hbase and kudu table are
passed in and there is no way to get hms table name from TableDescriptor
in backend.
After this change, for HBaseTableDescriptor and KuduTableDescriptor,
function name() would return hms table name, function table_name()
would return hbase or kudu native table name.
Manually tested on mini-cluster with:
1. hdfs and s3 table with file format text and parquet.
2. hbase table.
3. kudu table.
Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Reviewed-on: http://gerrit.cloudera.org:8080/14660
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hbase-scan-node.cc
M be/src/exec/hbase-table-writer.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/kudu-scan-node-base.cc
M fe/src/main/java/org/apache/impala/catalog/HBaseTable.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
6 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile
......................................................................
Patch Set 1:
Thanks Tim, I will update patch with Hbase and Kudu change.
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Nov 2019 18:40:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090: Add name of table being scanned in scan node profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090: Add name of table being scanned in scan node profile
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 16:59:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in scan node profile
Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090 Add name of table being scanned in scan node profile
......................................................................
IMPALA-9090 Add name of table being scanned in scan node profile
Before this change, the only way to figure out the table being scanned
by a scan node in the profile is to pull the string out of the explain
plan or execsummary. This is awkward, both for manual and automated
analysis of the profiles. We should include the table name as a string
in the SCAN_NODE implementation.
After this change, a new line "Table Name: database.table" will be added
in first line of scan node profile.
Manually tested on mini-cluster with:
1. hdfs and s3 table with file format text and parquet "test.hdfs_table",
it would show as "test.hdfs_table".
2. hbase table "test.hbase_table", if create with TBLPROPERTIES
("hbase.table.name" = "xyz", "hbase.mapred.output.outputtable" = "xyz")
it would show as "test.xyz"; if not, it would show as
"test.test.hbase_table".
3. kudu table "test.kudu_table", it would show as
"test.impala::test.kudu_table".
Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
---
M be/src/exec/hbase-scan-node.cc
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/kudu-scan-node-base.cc
3 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/14660/2
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in scan node profile
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090 Add name of table being scanned in scan node profile
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14660/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14660/2//COMMIT_MSG@24
PS2, Line 24: "test.test.hbase_table".
This seems buggy - I looked at "struct TTableDescriptor" and it says that tableName should be the unqualified name of the table, presumably the HMS table name, but I think the HbaseTable class in java is passing in the hbase table name incorrectly:
new TTableDescriptor(tableId, TTableType.HBASE_TABLE, getTColumnDescriptors(),
numClusteringCols_, hbaseTableName_, db_.getName());
It looks like table_name() is meant to be the native name of the Kudu and HBase tables. I think a few places in the kudu and hbase backend code are incorrectly using name() instead of table_name().
aggregator.cc: runtime_profile_, -1, runtime_profile_->name(), exec_node_->mem_tracker()));
data-source-scan-node.cc: col.__set_name(tuple_desc_->table_desc()->col_descs()[col_idx].name());
data-source-scan-node.cc: params.__set_table_name(tuple_desc_->table_desc()->name());
exec-node.cc: mem_tracker_.reset(new MemTracker(runtime_profile_, -1, runtime_profile_->name(),
hbase-table-writer.cc: RETURN_IF_ERROR(ExecEnv::GetInstance()->htable_factory()->GetTable(table_desc_->name(),
hdfs-avro-scanner.cc: scan_node_->hdfs_table()->col_descs()[slot_desc->col_pos()].name();
hdfs-scan-node-base.cc: hdfs_table_->database(), hdfs_table_->name())));
hdfs-table-sink.cc: partition_name_ss << table_desc_->col_descs()[j].name() << "=";
kudu-scanner.cc: << " Kudu table=" << scan_node_->table_->name();
kudu-scanner.cc: scan_node_->table_->name(),
kudu-scanner.cc: scan_node_->table_->schema().Column(slot->col_pos()).name())));
kudu-scanner.cc: scan_node_->table_->name());
kudu-table-sink.cc: "Table $0 has fewer columns than expected.", table_desc_->name()));
kudu-table-sink.cc: table_->schema().Column(col_idx).name(), type.DebugString(),
kudu-table-sink.cc: << table_->schema().Column(col).name()
parquet/hdfs-parquet-table-writer.cc: const string& col_name = table_desc_->col_descs()[i + num_clustering_cols].name();
parquet/parquet-metadata-utils.cc: const string& name = tbl_desc_.col_descs()[table_idx].name();
scan-node.cc: VLOG_RPC << "Thread started: " << thread->name();
scanner-context.cc: << parent_->scan_node_->hdfs_table()->name()
http://gerrit.cloudera.org:8080/#/c/14660/2//COMMIT_MSG@25
PS2, Line 25: 3. kudu table "test.kudu_table", it would show as
Same here - it looks like there's a pre-existing bug.
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 01:40:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 17:14:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090: Add name of table being scanned in scan node profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090: Add name of table being scanned in scan node profile
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 21:35:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in scan node profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090 Add name of table being scanned in scan node profile
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5054/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Nov 2019 23:40:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090: Add name of table being scanned in scan node profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090: Add name of table being scanned in scan node profile
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5079/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2019 03:27:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 )
Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile
......................................................................
Patch Set 1:
I probably should have asked in the JIRA to include it for all scan nodes (Kudu, Hbase, etc). I can start the merge as-is, since this is a good improvement, but I wouldn't mind if you looked at what it would take to add for the other node types.
--
To view, visit http://gerrit.cloudera.org:8080/14660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99
Gerrit-Change-Number: 14660
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 17:14:00 +0000
Gerrit-HasComments: No