[GitHub] [spark] srowen commented on a change in pull request #24388: [SPARK-27481][BUILD] Upgrade commons-logging to 1.1.3 for hadoop-3.2

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24388: [SPARK-27481][BUILD] Upgrade commons-logging to 1.1.3 for hadoop-3.2
URL: https://github.com/apache/spark/pull/24388#discussion_r276247890
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -487,6 +493,12 @@
         <groupId>commons-httpclient</groupId>
         <artifactId>commons-httpclient</artifactId>
         <version>${httpclient.classic.version}</version>
+        <exclusions>
 
 Review comment:
   I don't think we have to exclude this if we always override with a direct dependency.
   There are exceptions, because sometimes SBT's different dependency resolutions cause it to pick different versions and we have to force it with an exclusion. If you don't know we need this, I think it can be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org