[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9425: ARROW-11504: [Rust] Added checks to List DataType.

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #9425:
URL: https://github.com/apache/arrow/pull/9425#discussion_r576407591



##########
File path: rust/arrow/src/array/array_list.rs
##########
@@ -31,12 +31,19 @@ use crate::datatypes::*;
 
 /// trait declaring an offset size, relevant for i32 vs i64 array types.
 pub trait OffsetSizeTrait: ArrowNativeType + Num + Ord + std::ops::AddAssign {
+    fn is_large() -> bool;
+
     fn prefix() -> &'static str;
 
     fn to_isize(&self) -> isize;
 }
 
 impl OffsetSizeTrait for i32 {
+    #[inline]
+    fn is_large() -> bool {
+        false
+    }
+
     fn prefix() -> &'static str {

Review comment:
       I think that we can drop it, yes. We can merge StringOffset, BinaryOffset and OffsetTrait in a single Trait with this, but I wanted to leave it to another PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org