You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/05 00:00:25 UTC
[GitHub] graceguo-supercat commented on a change in pull request #4893: add
sticky to sidepane
graceguo-supercat commented on a change in pull request #4893: add sticky to sidepane
URL: https://github.com/apache/incubator-superset/pull/4893#discussion_r186244977
##########
File path: superset/assets/src/dashboard/components/Controls.jsx
##########
@@ -124,33 +116,25 @@ class Controls extends React.PureComponent {
expandedSlices={expandedSlices}
onSave={onSave}
css={this.state.css}
- triggerNode={
- <MenuItemContent
- text={editMode ? t('Save') : t('Save as')}
- tooltip={t('Save the dashboard')}
- />
- }
+ triggerNode={<span>{editMode ? t('Save') : t('Save as')}</span>}
isMenuItem
/>
{editMode && (
- <ActionMenuItem
- text={t('Edit properties')}
- tooltip={t("Edit the dashboards's properties")}
- onClick={() => {
- window.location = `/dashboardmodelview/edit/${
- this.props.dashboardInfo.id
- }`;
- }}
- />
+ <MenuItem
+ target="_blank"
+ href={`/dashboardmodelview/edit/${this.props.dashboardInfo.id}`}
+ >
+ {t('Edit dashboard metadata')}
+ </MenuItem>
)}
{editMode && (
- <ActionMenuItem
- text={t('Email')}
- tooltip={t('Email a link to this dashboard')}
+ <MenuItem
onClick={() => {
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org