You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2015/12/02 17:13:46 UTC
Review Request 40871: GEODE-184: The gfsh 'locate entry' command
fails to
find the entry on partitioned regions if the key is not a string
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40871/
-----------------------------------------------------------
Review request for geode, Barry Oglesby and Darrel Schneider.
Repository: geode
Description
-------
GEODE-184: The gfsh 'locate entry' command fails to find the entry on partitioned regions if the key is not a string
The bug report states exactly what the fix is. I'm also adding a test. Any ideas on how to make this a less heavy test would be good.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java d4dac05d7cfe9f775bdc1918c8d4621b1ae1bbb6
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionDUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/40871/diff/
Testing
-------
Ran distributedTest task
Thanks,
Jens Deppe
Re: Review Request 40871: GEODE-184: The gfsh 'locate entry' command
fails
to find the entry on partitioned regions if the key is not a string
Posted by Barry Oglesby <bo...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40871/#review108684
-----------------------------------------------------------
Ship it!
Ship It!
- Barry Oglesby
On Dec. 2, 2015, 5:40 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40871/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 5:40 p.m.)
>
>
> Review request for geode, Barry Oglesby and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-184: The gfsh 'locate entry' command fails to find the entry on partitioned regions if the key is not a string
>
> The bug report states exactly what the fix is. I'm also adding a test. Any ideas on how to make this a less heavy test would be good.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java d4dac05d7cfe9f775bdc1918c8d4621b1ae1bbb6
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40871/diff/
>
>
> Testing
> -------
>
> Ran distributedTest task
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 40871: GEODE-184: The gfsh 'locate entry' command
fails
to find the entry on partitioned regions if the key is not a string
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40871/#review108681
-----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionDUnitTest.java (line 35)
<https://reviews.apache.org/r/40871/#comment168140>
Consider making this test a JUnitTest. It runs in one jvm. Since you currently need a real PartitionedRegion it will need to be marked as an integration test.
Also should you add a comment that it currently only has test coverage for GEODE-184 and the other methods on DataCommandFunction need coverage?
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionDUnitTest.java (line 86)
<https://reviews.apache.org/r/40871/#comment168139>
why is this property set? Remove it if this test does not need it.
- Darrel Schneider
On Dec. 2, 2015, 9:40 a.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40871/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 9:40 a.m.)
>
>
> Review request for geode, Barry Oglesby and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-184: The gfsh 'locate entry' command fails to find the entry on partitioned regions if the key is not a string
>
> The bug report states exactly what the fix is. I'm also adding a test. Any ideas on how to make this a less heavy test would be good.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java d4dac05d7cfe9f775bdc1918c8d4621b1ae1bbb6
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40871/diff/
>
>
> Testing
> -------
>
> Ran distributedTest task
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 40871: GEODE-184: The gfsh 'locate entry' command
fails
to find the entry on partitioned regions if the key is not a string
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40871/#review108702
-----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionJUnitTest.java (line 96)
<https://reviews.apache.org/r/40871/#comment168161>
Better would be to get rid of the "system" and just create a cache. In tearDown call "this.cache.close()". This will also disconnect the DS that the cache owns.
Here is the cleanest code to create the cache (no need for a Properties object):
this.cache = new CacheFactory().set(DistributionConfig.MCAST_PORT_NAME, "0").create();
- Darrel Schneider
On Dec. 2, 2015, 11:07 a.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40871/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 11:07 a.m.)
>
>
> Review request for geode, Barry Oglesby and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-184: The gfsh 'locate entry' command fails to find the entry on partitioned regions if the key is not a string
>
> The bug report states exactly what the fix is. I'm also adding a test. Any ideas on how to make this a less heavy test would be good.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java d4dac05d7cfe9f775bdc1918c8d4621b1ae1bbb6
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40871/diff/
>
>
> Testing
> -------
>
> Ran distributedTest task
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 40871: GEODE-184: The gfsh 'locate entry' command
fails
to find the entry on partitioned regions if the key is not a string
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40871/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 8:52 p.m.)
Review request for geode, Barry Oglesby and Darrel Schneider.
Changes
-------
Streamlining cache setup
Repository: geode
Description
-------
GEODE-184: The gfsh 'locate entry' command fails to find the entry on partitioned regions if the key is not a string
The bug report states exactly what the fix is. I'm also adding a test. Any ideas on how to make this a less heavy test would be good.
Diffs (updated)
-----
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java d4dac05d7cfe9f775bdc1918c8d4621b1ae1bbb6
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionJUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/40871/diff/
Testing
-------
Ran distributedTest task
Thanks,
Jens Deppe
Re: Review Request 40871: GEODE-184: The gfsh 'locate entry' command
fails
to find the entry on partitioned regions if the key is not a string
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40871/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 7:07 p.m.)
Review request for geode, Barry Oglesby and Darrel Schneider.
Changes
-------
Per Darrel's suggestion, converted to an integration test.
Repository: geode
Description
-------
GEODE-184: The gfsh 'locate entry' command fails to find the entry on partitioned regions if the key is not a string
The bug report states exactly what the fix is. I'm also adding a test. Any ideas on how to make this a less heavy test would be good.
Diffs (updated)
-----
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java d4dac05d7cfe9f775bdc1918c8d4621b1ae1bbb6
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionJUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/40871/diff/
Testing
-------
Ran distributedTest task
Thanks,
Jens Deppe
Re: Review Request 40871: GEODE-184: The gfsh 'locate entry' command
fails
to find the entry on partitioned regions if the key is not a string
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40871/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 5:40 p.m.)
Review request for geode, Barry Oglesby and Darrel Schneider.
Changes
-------
Made change suggested by Jinmei
Repository: geode
Description
-------
GEODE-184: The gfsh 'locate entry' command fails to find the entry on partitioned regions if the key is not a string
The bug report states exactly what the fix is. I'm also adding a test. Any ideas on how to make this a less heavy test would be good.
Diffs (updated)
-----
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java d4dac05d7cfe9f775bdc1918c8d4621b1ae1bbb6
gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionDUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/40871/diff/
Testing
-------
Ran distributedTest task
Thanks,
Jens Deppe
Re: Review Request 40871: GEODE-184: The gfsh 'locate entry' command
fails
to find the entry on partitioned regions if the key is not a string
Posted by Barry Oglesby <bo...@pivotal.io>.
> On Dec. 2, 2015, 4:43 p.m., Jinmei Liao wrote:
> > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java, line 542
> > <https://reviews.apache.org/r/40871/diff/1/?file=1150581#file1150581line542>
> >
> > Just a question: should we use keyObject on this line as well, or no difference?
Yes, I think it should be used on this line too.
- Barry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40871/#review108665
-----------------------------------------------------------
On Dec. 2, 2015, 4:13 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40871/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 4:13 p.m.)
>
>
> Review request for geode, Barry Oglesby and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-184: The gfsh 'locate entry' command fails to find the entry on partitioned regions if the key is not a string
>
> The bug report states exactly what the fix is. I'm also adding a test. Any ideas on how to make this a less heavy test would be good.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java d4dac05d7cfe9f775bdc1918c8d4621b1ae1bbb6
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40871/diff/
>
>
> Testing
> -------
>
> Ran distributedTest task
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 40871: GEODE-184: The gfsh 'locate entry' command
fails
to find the entry on partitioned regions if the key is not a string
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40871/#review108665
-----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java (line 542)
<https://reviews.apache.org/r/40871/#comment168124>
Just a question: should we use keyObject on this line as well, or no difference?
- Jinmei Liao
On Dec. 2, 2015, 4:13 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40871/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 4:13 p.m.)
>
>
> Review request for geode, Barry Oglesby and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-184: The gfsh 'locate entry' command fails to find the entry on partitioned regions if the key is not a string
>
> The bug report states exactly what the fix is. I'm also adding a test. Any ideas on how to make this a less heavy test would be good.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunction.java d4dac05d7cfe9f775bdc1918c8d4621b1ae1bbb6
> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DataCommandFunctionDUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40871/diff/
>
>
> Testing
> -------
>
> Ran distributedTest task
>
>
> Thanks,
>
> Jens Deppe
>
>