You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ar...@apache.org on 2022/10/06 00:19:04 UTC
[impala] branch master updated (cf9c443dd -> 193265425)
This is an automated email from the ASF dual-hosted git repository.
arawat pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
from cf9c443dd IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala
new 010f1b943 IMPALA-11639: Upgrade Spring framework to 5.3.20
new 193265425 IMPALA-11637: Add DCHECK in AdmissionController::UpdateExecGroupMetric
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
be/src/scheduling/admission-controller.cc | 5 ++++-
java/pom.xml | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
[impala] 02/02: IMPALA-11637: Add DCHECK in AdmissionController::UpdateExecGroupMetric
Posted by ar...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
arawat pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 1932654252491e1e65cde06b54615a7a0fc2a8e1
Author: Riza Suminto <ri...@cloudera.com>
AuthorDate: Thu Sep 29 00:04:38 2022 -0700
IMPALA-11637: Add DCHECK in AdmissionController::UpdateExecGroupMetric
There has been occurrences where an impala backend crash and lead to
metric admission-controller.executor-group.num-queries-executing.*
goes negative. While we still investigating the exact scenario leading
into this negative metric issue, this patch add a DCHECK in
AdmissionController::UpdateExecGroupMetric to ensure that such case
does not happen in regular nightly tests.
Testing:
- Run and pass exhaustive test.
Change-Id: Icee9ae58d14d69a1548da3eccb51a00a7d727c13
Reviewed-on: http://gerrit.cloudera.org:8080/19095
Reviewed-by: Abhishek Rawat <ar...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
be/src/scheduling/admission-controller.cc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/be/src/scheduling/admission-controller.cc b/be/src/scheduling/admission-controller.cc
index 432f3196e..1e31813ba 100644
--- a/be/src/scheduling/admission-controller.cc
+++ b/be/src/scheduling/admission-controller.cc
@@ -2571,7 +2571,10 @@ void AdmissionController::UpdateExecGroupMetricMap(
void AdmissionController::UpdateExecGroupMetric(
const string& grp_name, int64_t delta) {
auto entry = exec_group_query_load_map_.find(grp_name);
- if (entry != exec_group_query_load_map_.end()) entry->second->Increment(delta);
+ if (entry != exec_group_query_load_map_.end()) {
+ DCHECK_GE(entry->second->GetValue() + delta, 0);
+ entry->second->Increment(delta);
+ }
}
} // namespace impala
[impala] 01/02: IMPALA-11639: Upgrade Spring framework to 5.3.20
Posted by ar...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
arawat pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 010f1b943c57178b26b86361cefe5a4f4273714d
Author: wzhou-code <wz...@cloudera.com>
AuthorDate: Tue Oct 4 12:33:30 2022 -0700
IMPALA-11639: Upgrade Spring framework to 5.3.20
This patch upgrade the Spring framework to 5.3.20 to
address multiple CVEs:
- CVE-2022-22971
- CVE-2022-22968
- CVE-2022-22970
Testing:
- Ran core job
- Ran custom cluster tests in exhaustive mode
Change-Id: I33f4f1d22fc27227e31d744658a17c16b61b9677
Reviewed-on: http://gerrit.cloudera.org:8080/19091
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
java/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/pom.xml b/java/pom.xml
index 5e0e6356a..d3d49ff91 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -74,7 +74,7 @@ under the License.
but bcprov-jdk15on matches the versions from pac4j 4.5.5. -->
<xmlsec.version>2.2.3</xmlsec.version>
<bcprov-jdk15on.version>1.68</bcprov-jdk15on.version>
- <springframework.version>5.3.18</springframework.version>
+ <springframework.version>5.3.20</springframework.version>
<json-smart.version>2.4.7</json-smart.version>
</properties>