[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #768: Add `StatusOr` for error handling in modern C++ style

[GitBox <gi...@apache.org>]

PragmaTwice commented on PR #768:
URL: https://github.com/apache/incubator-kvrocks/pull/768#issuecomment-1204698634

   > This approach may be a more modern C++ approach, but I don't think it's very friendly for a rookie like me. It may take me some time to get familiar with how to use `StatusOr` and what the implementation means, which may not be very friendly for a beginner like me to contribute code.
   > 
   > RocksDB as the storage engine, also uses the `Status` without major performance issues, so I think `Status` is better.
   
   First of all, I do not think contributors need to understand the implementation of `StatusOr`, just as they do not need to understand the implementation of `std::optional` (c++17), `std::varaint` (c++17), `std:;expected` (c++20), `std::any` or any other containers in STL (or called standard library). The interface of `StatusOr` is straightforward enough for all usage without learning it's implementation. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org