You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2025/05/26 19:37:19 UTC
[PR] misc(groovy-console): fix spelling [groovy]
jbampton opened a new pull request, #2236:
URL: https://github.com/apache/groovy/pull/2236
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] misc(groovy-console): fix spelling [groovy]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2236:
URL: https://github.com/apache/groovy/pull/2236#issuecomment-2910557140
## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2236?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `5 lines` in your changes missing coverage. Please review.
> Project coverage is 69.0378%. Comparing base [(`325aff6`)](https://app.codecov.io/gh/apache/groovy/commit/325aff6a5704b507fd43c2915ccaa698e14f0c9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0073c49`)](https://app.codecov.io/gh/apache/groovy/commit/0073c499199d9c2c4b0c3c988b4e4e4205c5ce50?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2236?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...onsole/ui/text/StructuredSyntaxDocumentFilter.java](https://app.codecov.io/gh/apache/groovy/pull/2236?src=pr&el=tree&filepath=subprojects%2Fgroovy-console%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fconsole%2Fui%2Ftext%2FStructuredSyntaxDocumentFilter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnNvbGUvc3JjL21haW4vZ3Jvb3Z5L2dyb292eS9jb25zb2xlL3VpL3RleHQvU3RydWN0dXJlZFN5bnRheERvY3VtZW50RmlsdGVyLmphdmE=) | 0.0000% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2236 +/- ##
=============================================
Coverage 69.0378% 69.0378%
+ Complexity 29706 29705 -1
=============================================
Files 1423 1423
Lines 114420 114420
Branches 19855 19855
=============================================
Hits 78993 78993
Misses 28788 28788
Partials 6639 6639
```
| [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2236?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...onsole/ui/text/StructuredSyntaxDocumentFilter.java](https://app.codecov.io/gh/apache/groovy/pull/2236?src=pr&el=tree&filepath=subprojects%2Fgroovy-console%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fconsole%2Fui%2Ftext%2FStructuredSyntaxDocumentFilter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnNvbGUvc3JjL21haW4vZ3Jvb3Z5L2dyb292eS9jb25zb2xlL3VpL3RleHQvU3RydWN0dXJlZFN5bnRheERvY3VtZW50RmlsdGVyLmphdmE=) | `0.5714% <0.0000%> (ø)` | |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2236/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] misc(groovy-console): fix spelling [groovy]
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert commented on PR #2236:
URL: https://github.com/apache/groovy/pull/2236#issuecomment-2910699905
Nice catch. To avoid breaking existing code, we'd keep the old accessor method and mark it as deprecated. Did you want to adjust your PR, or are you happy for us to tweak it after merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] misc(groovy-console): fix spelling [groovy]
Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on PR #2236:
URL: https://github.com/apache/groovy/pull/2236#issuecomment-2910702370
Thanks @paulk-asert I am happy for a merge now.
Perhaps you can tweak it after then I can see the format going forwards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] misc(groovy-console): fix spelling [groovy]
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert closed pull request #2236: misc(groovy-console): fix spelling
URL: https://github.com/apache/groovy/pull/2236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] misc(groovy-console): fix spelling [groovy]
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert commented on PR #2236:
URL: https://github.com/apache/groovy/pull/2236#issuecomment-2910721936
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org