You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "techdocsmith (via GitHub)" <gi...@apache.org> on 2023/12/07 16:43:25 UTC
[PR] update timeseries to reflect NULL filling (druid)
techdocsmith opened a new pull request, #15512:
URL: https://github.com/apache/druid/pull/15512
Updates timeseries docs to reflect the impact of `druid.generic.useDefaultValueForNull=false`
This PR has:
- [ x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] update timeseries to reflect NULL filling (druid)
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim merged PR #15512:
URL: https://github.com/apache/druid/pull/15512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] update timeseries to reflect NULL filling (druid)
Posted by "techdocsmith (via GitHub)" <gi...@apache.org>.
techdocsmith commented on code in PR #15512:
URL: https://github.com/apache/druid/pull/15512#discussion_r1419705787
##########
docs/querying/timeseriesquery.md:
##########
@@ -126,10 +126,11 @@ The grand totals row will appear as the last row in the result array, and will h
row even if the query is run in "descending" mode. Post-aggregations in the grand totals row will be computed based
upon the grand total aggregations.
-## Zero-filling
+## Empty bucket values
-Timeseries queries normally fill empty interior time buckets with zeroes. For example, if you issue a "day" granularity
-timeseries query for the interval 2012-01-01/2012-01-04, and no data exists for 2012-01-02, you will receive:
+By default Druid fills empty interior time buckets in responses to timeseries queries with the default value for the [aggregator function](./sql-aggregations.md).
Review Comment:
```suggestion
By default Druid fills empty interior time buckets in the results of timeseries queries with the default value for the [aggregator function](./sql-aggregations.md).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] update timeseries to reflect NULL filling (druid)
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis commented on code in PR #15512:
URL: https://github.com/apache/druid/pull/15512#discussion_r1419651552
##########
docs/querying/timeseriesquery.md:
##########
@@ -126,9 +126,10 @@ The grand totals row will appear as the last row in the result array, and will h
row even if the query is run in "descending" mode. Post-aggregations in the grand totals row will be computed based
upon the grand total aggregations.
-## Zero-filling
+## NULL filling
Review Comment:
I wonder if we should call this "Empty filling" or "Empty bucket filling" or something similar?
It doesn't actually always fill with zeros or nulls depending on the mode, rather it fills with the default values of the aggregator functions. Since they aggregate no rows, only the default value is there. https://github.com/apache/druid/blob/master/docs/querying/sql-aggregations.md has the default values of the aggregators.
##########
docs/querying/timeseriesquery.md:
##########
@@ -126,9 +126,10 @@ The grand totals row will appear as the last row in the result array, and will h
row even if the query is run in "descending" mode. Post-aggregations in the grand totals row will be computed based
upon the grand total aggregations.
-## Zero-filling
+## NULL filling
-Timeseries queries normally fill empty interior time buckets with zeroes. For example, if you issue a "day" granularity
+By default timeseries queries fill empty interior time buckets with NULL.
Review Comment:
same comment about default aggregator value(s), and in other places too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] update timeseries to reflect NULL filling (druid)
Posted by "techdocsmith (via GitHub)" <gi...@apache.org>.
techdocsmith commented on code in PR #15512:
URL: https://github.com/apache/druid/pull/15512#discussion_r1419700827
##########
docs/querying/timeseriesquery.md:
##########
@@ -148,12 +149,11 @@ timeseries query for the interval 2012-01-01/2012-01-04, and no data exists for
]
```
-Time buckets that lie completely outside the data interval are not zero-filled.
+Time buckets that lie completely outside the data interval are not filled with the default value.
-You can disable all zero-filling with the context flag "skipEmptyBuckets". In this mode, the data point for 2012-01-02
-would be omitted from the results.
-
-A query with this context flag set would look like:
+You can disable all NULL filling with the context flag "skipEmptyBuckets".
Review Comment:
```suggestion
You can disable all empty bucket filling with the context flag "skipEmptyBuckets".
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] update timeseries to reflect NULL filling (druid)
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #15512:
URL: https://github.com/apache/druid/pull/15512#discussion_r1419704128
##########
docs/querying/timeseriesquery.md:
##########
@@ -126,10 +126,11 @@ The grand totals row will appear as the last row in the result array, and will h
row even if the query is run in "descending" mode. Post-aggregations in the grand totals row will be computed based
upon the grand total aggregations.
-## Zero-filling
+## Empty bucket values
-Timeseries queries normally fill empty interior time buckets with zeroes. For example, if you issue a "day" granularity
-timeseries query for the interval 2012-01-01/2012-01-04, and no data exists for 2012-01-02, you will receive:
+By default Druid fills empty interior time buckets in responses to timeseries queries with the default value for the [aggregator function](./sql-aggregations.md).
Review Comment:
>in responses to
Should this be “in response to”? Or “in the results of”?
##########
docs/querying/timeseriesquery.md:
##########
@@ -126,10 +126,11 @@ The grand totals row will appear as the last row in the result array, and will h
row even if the query is run in "descending" mode. Post-aggregations in the grand totals row will be computed based
upon the grand total aggregations.
-## Zero-filling
+## Empty bucket values
-Timeseries queries normally fill empty interior time buckets with zeroes. For example, if you issue a "day" granularity
-timeseries query for the interval 2012-01-01/2012-01-04, and no data exists for 2012-01-02, you will receive:
+By default Druid fills empty interior time buckets in responses to timeseries queries with the default value for the [aggregator function](./sql-aggregations.md).
Review Comment:
>in responses to
Should this be “in response to”? Or “in the results of”?
##########
docs/querying/timeseriesquery.md:
##########
@@ -126,10 +126,11 @@ The grand totals row will appear as the last row in the result array, and will h
row even if the query is run in "descending" mode. Post-aggregations in the grand totals row will be computed based
upon the grand total aggregations.
-## Zero-filling
+## Empty bucket values
-Timeseries queries normally fill empty interior time buckets with zeroes. For example, if you issue a "day" granularity
-timeseries query for the interval 2012-01-01/2012-01-04, and no data exists for 2012-01-02, you will receive:
+By default Druid fills empty interior time buckets in responses to timeseries queries with the default value for the [aggregator function](./sql-aggregations.md).
Review Comment:
>in responses to
Should this be “in response to”? Or “in the results of”?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] update timeseries to reflect NULL filling (druid)
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #15512:
URL: https://github.com/apache/druid/pull/15512#discussion_r1419704707
##########
docs/querying/timeseriesquery.md:
##########
@@ -148,12 +149,11 @@ timeseries query for the interval 2012-01-01/2012-01-04, and no data exists for
]
```
-Time buckets that lie completely outside the data interval are not zero-filled.
+Time buckets that lie completely outside the data interval are not filled with the default value.
-You can disable all zero-filling with the context flag "skipEmptyBuckets". In this mode, the data point for 2012-01-02
-would be omitted from the results.
-
-A query with this context flag set would look like:
+You can disable all empty bucket filling with the context flag "skipEmptyBuckets".
Review Comment:
```suggestion
You can disable all empty bucket filling with the context flag `skipEmptyBuckets`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org