You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/03/13 19:10:44 UTC
svn commit: r1887606 -
/pdfbox/branches/2.0/xmpbox/src/main/java/org/apache/xmpbox/DateConverter.java
Author: tilman
Date: Sat Mar 13 19:10:43 2021
New Revision: 1887606
URL: http://svn.apache.org/viewvc?rev=1887606&view=rev
Log:
PDFBOX-4892: unnecessary convertion removed, as suggested by valerybokov; use char instead of string for single character
Modified:
pdfbox/branches/2.0/xmpbox/src/main/java/org/apache/xmpbox/DateConverter.java
Modified: pdfbox/branches/2.0/xmpbox/src/main/java/org/apache/xmpbox/DateConverter.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/xmpbox/src/main/java/org/apache/xmpbox/DateConverter.java?rev=1887606&r1=1887605&r2=1887606&view=diff
==============================================================================
--- pdfbox/branches/2.0/xmpbox/src/main/java/org/apache/xmpbox/DateConverter.java (original)
+++ pdfbox/branches/2.0/xmpbox/src/main/java/org/apache/xmpbox/DateConverter.java Sat Mar 13 19:10:43 2021
@@ -292,31 +292,31 @@ public final class DateConverter
StringBuilder retval = new StringBuilder();
retval.append(cal.get(Calendar.YEAR));
- retval.append("-");
+ retval.append('-');
retval.append(String.format(Locale.US, "%02d", cal.get(Calendar.MONTH) + 1));
- retval.append("-");
+ retval.append('-');
retval.append(String.format(Locale.US, "%02d", cal.get(Calendar.DAY_OF_MONTH)));
- retval.append("T");
+ retval.append('T');
retval.append(String.format(Locale.US, "%02d", cal.get(Calendar.HOUR_OF_DAY)));
- retval.append(":");
+ retval.append(':');
retval.append(String.format(Locale.US, "%02d", cal.get(Calendar.MINUTE)));
- retval.append(":");
+ retval.append(':');
retval.append(String.format(Locale.US, "%02d", cal.get(Calendar.SECOND)));
if (printMillis)
{
- retval.append(".");
+ retval.append('.');
retval.append(String.format(Locale.US, "%03d", cal.get(Calendar.MILLISECOND)));
}
int timeZone = cal.get(Calendar.ZONE_OFFSET) + cal.get(Calendar.DST_OFFSET);
if (timeZone < 0)
{
- retval.append("-");
+ retval.append('-');
}
else
{
- retval.append("+");
+ retval.append('+');
}
timeZone = Math.abs(timeZone);
// milliseconds/1000 = seconds; seconds / 60 = minutes; minutes/60 = hours
@@ -324,15 +324,15 @@ public final class DateConverter
int minutes = (timeZone - (hours * 1000 * 60 * 60)) / 1000 / 60;
if (hours < 10)
{
- retval.append("0");
+ retval.append('0');
}
- retval.append(Integer.toString(hours));
- retval.append(":");
+ retval.append(hours);
+ retval.append(':');
if (minutes < 10)
{
- retval.append("0");
+ retval.append('0');
}
- retval.append(Integer.toString(minutes));
+ retval.append(minutes);
return retval.toString();
}