You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/09/08 13:16:12 UTC
[GitHub] [ozone] JacksonYao287 opened a new pull request #2626: HDDS-5729. support setting maxSizeEnteringTarget and maxSizeLeavingSource in command line
JacksonYao287 opened a new pull request #2626:
URL: https://github.com/apache/ozone/pull/2626
## What changes were proposed in this pull request?
add container balancer command line parameters
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5729
## How was this patch tested?
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lokeshj1703 merged pull request #2626: HDDS-5729. support setting maxSizeEnteringTarget and maxSizeLeavingSource in command line
Posted by GitBox <gi...@apache.org>.
lokeshj1703 merged pull request #2626:
URL: https://github.com/apache/ozone/pull/2626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] siddhantsangwan commented on pull request #2626: HDDS-5729. support setting maxSizeEnteringTarget and maxSizeLeavingSource in command line
Posted by GitBox <gi...@apache.org>.
siddhantsangwan commented on pull request #2626:
URL: https://github.com/apache/ozone/pull/2626#issuecomment-915770869
Note that currently ContainerBalancer doesn't support the `maxSizeLeavingSource` configuration. Only one container can move from a source datanode right now. We can add support for this config in [HDDS-5517](https://issues.apache.org/jira/browse/HDDS-5517).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] siddhantsangwan commented on pull request #2626: HDDS-5729. support setting maxSizeEnteringTarget and maxSizeLeavingSource in command line
Posted by GitBox <gi...@apache.org>.
siddhantsangwan commented on pull request #2626:
URL: https://github.com/apache/ozone/pull/2626#issuecomment-918882073
This looks good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lokeshj1703 commented on pull request #2626: HDDS-5729. support setting maxSizeEnteringTarget and maxSizeLeavingSource in command line
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #2626:
URL: https://github.com/apache/ozone/pull/2626#issuecomment-919881683
@JacksonYao287 Thanks for working on this PR! @siddhantsangwan Thanks for the review! I have committed the PR to master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on a change in pull request #2626: HDDS-5729. support setting maxSizeEnteringTarget and maxSizeLeavingSource in command line
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on a change in pull request #2626:
URL: https://github.com/apache/ozone/pull/2626#discussion_r708313209
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java
##########
@@ -54,10 +54,21 @@
"for 10GB it should be set as 10")
private Optional<Long> maxSizeToMovePerIterationInGB;
+ @Option(names = {"-e", "--maxSizeEnteringTarget"},
+ description = "the maximum size that can enter a target datanode while " +
+ "balancing in GB. This is the sum of data from multiple sources.")
+ private Optional<Long> maxSizeEnteringTarget;
+
+ @Option(names = {"-l", "--maxSizeLeavingSource"},
+ description = "maximum size that can leave a source datanode while " +
+ "balancing in GB, it is the sum of data moving to multiple targets.")
+ private Optional<Long> maxSizeLeavingSource;
+
Review comment:
yea, i will do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2626: HDDS-5729. support setting maxSizeEnteringTarget and maxSizeLeavingSource in command line
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2626:
URL: https://github.com/apache/ozone/pull/2626#issuecomment-915875760
> Note that currently ContainerBalancer doesn't support the `maxSizeLeavingSource` configuration. Only one container can move from a source datanode right now. We can add support for this config in [HDDS-5517](https://issues.apache.org/jira/browse/HDDS-5517).
ok, we can add `maxSizeLeavingSource` for now and do not set it explicitly until HDDS-5517 is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lokeshj1703 commented on a change in pull request #2626: HDDS-5729. support setting maxSizeEnteringTarget and maxSizeLeavingSource in command line
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on a change in pull request #2626:
URL: https://github.com/apache/ozone/pull/2626#discussion_r708137550
##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java
##########
@@ -54,10 +54,21 @@
"for 10GB it should be set as 10")
private Optional<Long> maxSizeToMovePerIterationInGB;
+ @Option(names = {"-e", "--maxSizeEnteringTarget"},
+ description = "the maximum size that can enter a target datanode while " +
+ "balancing in GB. This is the sum of data from multiple sources.")
+ private Optional<Long> maxSizeEnteringTarget;
+
+ @Option(names = {"-l", "--maxSizeLeavingSource"},
+ description = "maximum size that can leave a source datanode while " +
+ "balancing in GB, it is the sum of data moving to multiple targets.")
+ private Optional<Long> maxSizeLeavingSource;
+
Review comment:
NIT: Use InGB suffix similar to maxSizeToMovePerIterationInGB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 edited a comment on pull request #2626: HDDS-5729. support setting maxSizeEnteringTarget and maxSizeLeavingSource in command line
Posted by GitBox <gi...@apache.org>.
JacksonYao287 edited a comment on pull request #2626:
URL: https://github.com/apache/ozone/pull/2626#issuecomment-915230236
@lokeshj1703 @siddhantsangwan PTAL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JacksonYao287 commented on pull request #2626: HDDS-5729. support setting maxSizeEnteringTarget and maxSizeLeavingSource in command line
Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on pull request #2626:
URL: https://github.com/apache/ozone/pull/2626#issuecomment-915230236
@lokeshj1703 PTAL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org