You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/09 14:02:31 UTC
[GitHub] [arrow] davisusanibar opened a new pull request, #13352: ARROW-16554: [Java] Download Java nightlies artifacts from https://nightlies.apache.org/arrow/java/org/apache/arrow/
davisusanibar opened a new pull request, #13352:
URL: https://github.com/apache/arrow/pull/13352
Download Java nightlies artifacts from https://nightlies.apache.org/arrow/java/org/apache/arrow/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #13352: ARROW-16554: [Java] Download Java nightlies artifacts from https://nightlies.apache.org/arrow/java/org/apache/arrow/
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #13352:
URL: https://github.com/apache/arrow/pull/13352#discussion_r893583186
##########
docs/source/java/install.rst:
##########
@@ -143,8 +143,31 @@ Installing Nightly Packages
Arrow nightly builds are posted on the mailing list at `builds@arrow.apache.org`_.
The artifacts are uploaded to GitHub. For example, for 2022/03/01, they can be found at `Github Nightly`_.
-Maven cannot directly use the artifacts from GitHub.
-Instead, install them to the local Maven repository:
+Installing from Apache Nightlies
+********************************
+
+Steps involved to install to local Maven repository using Apache Nightlies Repository:
+
+1. Is needed to add Apache Nightlies Repository to the Maven/Gradle project. For Maven pom.xml is needed to add arrow/java directory.
+
+.. code-block:: xml
+
+ <properties>
+ <arrow.version>9.0.0.dev191</arrow.version>
Review Comment:
This is an incremental directory, it means we haver more Java artifacts as more nightly build do we have. Pending to define what could the maximum versions storage.
Adding more detail on the steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13352: ARROW-16554: [Java] Download Java nightlies artifacts from https://nightlies.apache.org/arrow/java/org/apache/arrow/
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13352:
URL: https://github.com/apache/arrow/pull/13352#discussion_r893585264
##########
docs/source/java/install.rst:
##########
@@ -143,8 +143,40 @@ Installing Nightly Packages
Arrow nightly builds are posted on the mailing list at `builds@arrow.apache.org`_.
The artifacts are uploaded to GitHub. For example, for 2022/03/01, they can be found at `Github Nightly`_.
-Maven cannot directly use the artifacts from GitHub.
-Instead, install them to the local Maven repository:
+Installing from Apache Nightlies
+********************************
+
+Steps involved to download Java artifacts from Apache Nightlies Repository:
+
+1. Once you have the Java nightly library needed (i.e. arrow-memory), please go to https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-memory/ and see what version are available (i.e. 9.0.0.dev191), this is alligned with Arrow nightly builds.
Review Comment:
```suggestion
1. Look up the nightly version number for the Arrow libraries used.
For example, for ``arrow-memory``, visit https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-memory/ and see what versions are available (e.g. 9.0.0.dev191).
```
##########
docs/source/java/install.rst:
##########
@@ -143,8 +143,40 @@ Installing Nightly Packages
Arrow nightly builds are posted on the mailing list at `builds@arrow.apache.org`_.
The artifacts are uploaded to GitHub. For example, for 2022/03/01, they can be found at `Github Nightly`_.
-Maven cannot directly use the artifacts from GitHub.
-Instead, install them to the local Maven repository:
+Installing from Apache Nightlies
+********************************
+
+Steps involved to download Java artifacts from Apache Nightlies Repository:
+
Review Comment:
```suggestion
```
##########
docs/source/java/install.rst:
##########
@@ -143,8 +143,40 @@ Installing Nightly Packages
Arrow nightly builds are posted on the mailing list at `builds@arrow.apache.org`_.
The artifacts are uploaded to GitHub. For example, for 2022/03/01, they can be found at `Github Nightly`_.
-Maven cannot directly use the artifacts from GitHub.
-Instead, install them to the local Maven repository:
+Installing from Apache Nightlies
+********************************
+
+Steps involved to download Java artifacts from Apache Nightlies Repository:
+
+1. Once you have the Java nightly library needed (i.e. arrow-memory), please go to https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-memory/ and see what version are available (i.e. 9.0.0.dev191), this is alligned with Arrow nightly builds.
Review Comment:
(not sure about the reST formatting here, please correct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13352: ARROW-16554: [Java] Download Java nightlies artifacts from https://nightlies.apache.org/arrow/java/org/apache/arrow/
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13352:
URL: https://github.com/apache/arrow/pull/13352#discussion_r893586344
##########
docs/source/java/install.rst:
##########
@@ -143,8 +143,40 @@ Installing Nightly Packages
Arrow nightly builds are posted on the mailing list at `builds@arrow.apache.org`_.
The artifacts are uploaded to GitHub. For example, for 2022/03/01, they can be found at `Github Nightly`_.
-Maven cannot directly use the artifacts from GitHub.
-Instead, install them to the local Maven repository:
+Installing from Apache Nightlies
+********************************
+
+Steps involved to download Java artifacts from Apache Nightlies Repository:
+
+1. Once you have the Java nightly library needed (i.e. arrow-memory), please go to https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-memory/ and see what version are available (i.e. 9.0.0.dev191), this is alligned with Arrow nightly builds.
+2. Add Apache Nightlies Repository to the Maven/Gradle project.
+
+.. code-block:: xml
+
+ <properties>
+ <arrow.version>9.0.0.dev191</arrow.version>
+ </properties>
+ ...
+ <repositories>
+ <repository>
+ <id>arrow-apache-nightlies</id>
+ <url>https://nightlies.apache.org/arrow/java</url>
+ </repository>
+ </repositories>
+ ...
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.arrow</groupId>
+ <artifactId>arrow-vector</artifactId>
+ <version>${arrow.version}</version>
+ </dependency>
+ </dependencies>
+ ...
+
+Installing Manually
+*******************
+
+Steps involved to install to local Maven repository manually:
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13352: ARROW-16554: [Java] Download Java nightlies artifacts from https://nightlies.apache.org/arrow/java/org/apache/arrow/
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13352:
URL: https://github.com/apache/arrow/pull/13352#issuecomment-1151161902
https://issues.apache.org/jira/browse/ARROW-16554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on pull request #13352: ARROW-16554: [Java] Download Java nightlies artifacts from https://nightlies.apache.org/arrow/java/org/apache/arrow/
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on PR #13352:
URL: https://github.com/apache/arrow/pull/13352#issuecomment-1151253340
> The instructions work from a quick test, I think we can just clarify the wording
Just compiling that locally and it is rendering properly. Thank you.
There are points needed to review as an improvement about the version number ready to use, this is going to be managed in another PR after the CI Java is implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13352: ARROW-16554: [Java] Download Java nightlies artifacts from https://nightlies.apache.org/arrow/java/org/apache/arrow/
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13352:
URL: https://github.com/apache/arrow/pull/13352#discussion_r893708442
##########
docs/source/java/install.rst:
##########
@@ -143,8 +143,37 @@ Installing Nightly Packages
Arrow nightly builds are posted on the mailing list at `builds@arrow.apache.org`_.
The artifacts are uploaded to GitHub. For example, for 2022/03/01, they can be found at `Github Nightly`_.
-Maven cannot directly use the artifacts from GitHub.
-Instead, install them to the local Maven repository:
+Installing from Apache Nightlies
+********************************
+1. Look up the nightly version number for the Arrow libraries used.
+
+ For example, for ``arrow-memory``, visit https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-memory/ and see what versions are available (e.g. 9.0.0.dev191).
Review Comment:
```suggestion
1. Look up the nightly version number for the Arrow libraries used.
For example, for ``arrow-memory``, visit https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-memory/ and see what versions are available (e.g. 9.0.0.dev191).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- commented on a diff in pull request #13352: ARROW-16554: [Java] Download Java nightlies artifacts from https://nightlies.apache.org/arrow/java/org/apache/arrow/
Posted by GitBox <gi...@apache.org>.
amol- commented on code in PR #13352:
URL: https://github.com/apache/arrow/pull/13352#discussion_r893564473
##########
docs/source/java/install.rst:
##########
@@ -143,8 +143,31 @@ Installing Nightly Packages
Arrow nightly builds are posted on the mailing list at `builds@arrow.apache.org`_.
The artifacts are uploaded to GitHub. For example, for 2022/03/01, they can be found at `Github Nightly`_.
-Maven cannot directly use the artifacts from GitHub.
-Instead, install them to the local Maven repository:
+Installing from Apache Nightlies
+********************************
+
+Steps involved to install to local Maven repository using Apache Nightlies Repository:
+
+1. Is needed to add Apache Nightlies Repository to the Maven/Gradle project. For Maven pom.xml is needed to add arrow/java directory.
+
+.. code-block:: xml
+
+ <properties>
+ <arrow.version>9.0.0.dev191</arrow.version>
Review Comment:
Does the nightlies directory contain only 1 nightly build? Shouldn't it contain multiple nightly builds? I think it was mentioned to keep around a few weeks of them.
In such case, how does the user know which version to put here? We might want to write somewhere that you are expected to go to https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-memory/ (for example) and see which versions are vailable, or have some other way to know which is the right version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #13352: ARROW-16554: [Java] Download Java nightlies artifacts from https://nightlies.apache.org/arrow/java/org/apache/arrow/
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #13352:
URL: https://github.com/apache/arrow/pull/13352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13352: ARROW-16554: [Java] Download Java nightlies artifacts from https://nightlies.apache.org/arrow/java/org/apache/arrow/
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13352:
URL: https://github.com/apache/arrow/pull/13352#issuecomment-1151205244
The instructions work from a quick test, I think we can just clarify the wording
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org