You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/02 16:48:56 UTC
[GitHub] [spark] naveensrinivasan opened a new pull request #34163: Pin actions to a full length commit SHA
naveensrinivasan opened a new pull request #34163:
URL: https://github.com/apache/spark/pull/34163
### What changes were proposed in this pull request?
Pinning github actions to a SHA
### Why are the changes needed?
Pinning an action to a full length commit SHA is currently the only way to use an action as
an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a
backdoor to the action's repository, as they would need to generate a SHA-1 collision for
a valid Git object payload.
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies
### Does this PR introduce _any_ user-facing change?
Running github action and checking the SHA with the existing repository
### How was this patch tested?
Running the GitHub action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932863567
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48319/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932866565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r726672606
##########
File path: .github/workflows/cancel_duplicate_workflow_runs.yml
##########
@@ -29,7 +29,7 @@ jobs:
name: "Cancel duplicate workflow runs"
runs-on: ubuntu-latest
steps:
- - uses: potiuk/cancel-workflow-runs@953e057dc81d3458935a18d1184c386b0f6b5738 # @master
+ - uses: potiuk/cancel-workflow-runs@4723494a065d162f8e9efd071b98e0126e00f866 # @master
Review comment:
cc @potiuk FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940181207
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48566/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940159860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] naveensrinivasan commented on a change in pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
naveensrinivasan commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r726144351
##########
File path: .github/workflows/labeler.yml
##########
@@ -22,7 +22,6 @@
# currently randomly picks any associated workflow.
# So, the name was changed to make sense in that context too.
# See also https://github.community/t/specify-check-suite-when-creating-a-checkrun/118380/10
-
Review comment:
What changes are required here? Maybe I have already addressed it. Please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r726671839
##########
File path: .github/workflows/stale.yml
##########
@@ -21,23 +21,22 @@ name: Close stale PRs
on:
schedule:
- - cron: "0 0 * * *"
+ - cron: "0 0 * * *"
jobs:
stale:
runs-on: ubuntu-latest
steps:
- - uses: actions/stale@v1.1.0
- with:
- repo-token: ${{ secrets.GITHUB_TOKEN }}
- stale-pr-message: >
- We're closing this PR because it hasn't been updated in a while.
- This isn't a judgement on the merit of the PR in any way. It's just
- a way of keeping the PR queue manageable.
+ - uses: actions/stale@c201d45ef4b0ccbd3bb0616f93bae13e73d0a080 # pin@v1.1.0
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+ stale-pr-message: >
+ We're closing this PR because it hasn't been updated in a while.
+ This isn't a judgement on the merit of the PR in any way. It's just
+ a way of keeping the PR queue manageable.
- If you'd like to revive this PR, please reopen it and ask a
- committer to remove the Stale tag!
- days-before-stale: 100
- # Setting this to 0 is the same as setting it to 1.
- # See: https://github.com/actions/stale/issues/28
- days-before-close: 0
+ If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
+ days-before-stale: 100
+ # Setting this to 0 is the same as setting it to 1.
+ # See: https://github.com/actions/stale/issues/28
+ days-before-close: 0
Review comment:
```suggestion
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
days-before-stale: 100
# Setting this to 0 is the same as setting it to 1.
# See: https://github.com/actions/stale/issues/28
days-before-close: 0
```
##########
File path: .github/workflows/update_build_status.yml
##########
@@ -21,15 +21,15 @@ name: Update build status workflow
on:
schedule:
- - cron: "*/15 * * * *"
+ - cron: "*/15 * * * *"
Review comment:
```suggestion
- cron: "*/15 * * * *"
```
##########
File path: .github/workflows/test_report.yml
##########
@@ -20,25 +20,25 @@
name: Report test results
on:
workflow_run:
- workflows: ["Build and test"]
+ workflows: [ "Build and test" ]
Review comment:
```suggestion
workflows: ["Build and test"]
```
##########
File path: .github/workflows/notify_test_workflow.yml
##########
@@ -25,15 +25,15 @@
name: On pull request update
on:
pull_request_target:
- types: [opened, reopened, synchronize]
+ types: [ opened, reopened, synchronize ]
Review comment:
```suggestion
types: [opened, reopened, synchronize]
```
##########
File path: .github/workflows/test_report.yml
##########
@@ -20,25 +20,25 @@
name: Report test results
on:
workflow_run:
- workflows: ["Build and test"]
+ workflows: [ "Build and test" ]
types:
- completed
jobs:
test_report:
runs-on: ubuntu-latest
steps:
- - name: Download test results to report
- uses: dawidd6/action-download-artifact@v2
- with:
- github_token: ${{ secrets.GITHUB_TOKEN }}
- workflow: ${{ github.event.workflow_run.workflow_id }}
- commit: ${{ github.event.workflow_run.head_commit.id }}
- workflow_conclusion: completed
- - name: Publish test report
- uses: scacap/action-surefire-report@v1
- with:
- check_name: Report test results
- github_token: ${{ secrets.GITHUB_TOKEN }}
- report_paths: "**/target/test-reports/*.xml"
- commit: ${{ github.event.workflow_run.head_commit.id }}
+ - name: Download test results to report
+ uses: dawidd6/action-download-artifact@6f8f427fb41886a66b82ea11a5a15d1454c79415 # pin@v2
+ with:
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ workflow: ${{ github.event.workflow_run.workflow_id }}
+ commit: ${{ github.event.workflow_run.head_commit.id }}
+ workflow_conclusion: completed
+ - name: Publish test report
+ uses: scacap/action-surefire-report@482f012643ed0560e23ef605a79e8e87ca081648 # pin@v1
+ with:
+ check_name: Report test results
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ report_paths: "**/target/test-reports/*.xml"
+ commit: ${{ github.event.workflow_run.head_commit.id }}
Review comment:
```suggestion
- name: Download test results to report
uses: dawidd6/action-download-artifact@6f8f427fb41886a66b82ea11a5a15d1454c79415 # pin@v2
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
workflow: ${{ github.event.workflow_run.workflow_id }}
commit: ${{ github.event.workflow_run.head_commit.id }}
workflow_conclusion: completed
- name: Publish test report
uses: scacap/action-surefire-report@482f012643ed0560e23ef605a79e8e87ca081648 # pin@v1
with:
check_name: Report test results
github_token: ${{ secrets.GITHUB_TOKEN }}
report_paths: "**/target/test-reports/*.xml"
commit: ${{ github.event.workflow_run.head_commit.id }}
```
##########
File path: .github/workflows/stale.yml
##########
@@ -21,23 +21,22 @@ name: Close stale PRs
on:
schedule:
- - cron: "0 0 * * *"
+ - cron: "0 0 * * *"
Review comment:
```suggestion
- cron: "0 0 * * *"
```
##########
File path: .github/workflows/stale.yml
##########
@@ -21,23 +21,22 @@ name: Close stale PRs
on:
schedule:
- - cron: "0 0 * * *"
+ - cron: "0 0 * * *"
jobs:
stale:
runs-on: ubuntu-latest
steps:
- - uses: actions/stale@v1.1.0
- with:
- repo-token: ${{ secrets.GITHUB_TOKEN }}
- stale-pr-message: >
- We're closing this PR because it hasn't been updated in a while.
- This isn't a judgement on the merit of the PR in any way. It's just
- a way of keeping the PR queue manageable.
+ - uses: actions/stale@c201d45ef4b0ccbd3bb0616f93bae13e73d0a080 # pin@v1.1.0
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+ stale-pr-message: >
+ We're closing this PR because it hasn't been updated in a while.
+ This isn't a judgement on the merit of the PR in any way. It's just
+ a way of keeping the PR queue manageable.
Review comment:
```suggestion
- uses: actions/stale@c201d45ef4b0ccbd3bb0616f93bae13e73d0a080 # pin@v1.1.0
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-pr-message: >
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just
a way of keeping the PR queue manageable.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #34163:
URL: https://github.com/apache/spark/pull/34163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932871634
**[Test build #143807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143807/testReport)** for PR 34163 at commit [`7c0f197`](https://github.com/apache/spark/commit/7c0f1973a312c4cdad75e02e757b33447d9ca921).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34163: [SPARK-36915] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r721804151
##########
File path: .github/workflows/publish_snapshot.yml
##########
@@ -35,26 +35,26 @@ jobs:
- branch-3.2
- branch-3.1
steps:
- - name: Checkout Spark repository
- uses: actions/checkout@master
- with:
- ref: ${{ matrix.branch }}
- - name: Cache Maven local repository
- uses: actions/cache@v2
- with:
- path: ~/.m2/repository
- key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
- restore-keys: |
- snapshot-maven-
- - name: Install Java 8
- uses: actions/setup-java@v1
- with:
- java-version: 8
- - name: Publish snapshot
- env:
- ASF_USERNAME: ${{ secrets.NEXUS_USER }}
- ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
- GPG_KEY: "not_used"
- GPG_PASSPHRASE: "not_used"
- GIT_REF: ${{ matrix.branch }}
- run: ./dev/create-release/release-build.sh publish-snapshot
+ - name: Checkout Spark repository
Review comment:
sorry it's a nit but let's remove these indentation changes too. I would like to backport this commit to other branches as are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940201867
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48566/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932855811
Let's also file a JIRA to track these security issues (see also https://spark.apache.org/contributing.html). Otherwise, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932866565
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48319/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r721804535
##########
File path: .github/workflows/labeler.yml
##########
@@ -22,7 +22,6 @@
# currently randomly picks any associated workflow.
# So, the name was changed to make sense in that context too.
# See also https://github.community/t/specify-check-suite-when-creating-a-checkrun/118380/10
-
Review comment:
Let's revert this part too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940106280
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48563/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940592401
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932993968
**[Test build #143811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143811/testReport)** for PR 34163 at commit [`c411a56`](https://github.com/apache/spark/commit/c411a5645ee04b44647540f4f57c6d0a162596f0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932866568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940613196
**[Test build #144108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144108/testReport)** for PR 34163 at commit [`411d813`](https://github.com/apache/spark/commit/411d813e98b3fd399b6b22778df6954f09e41119).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932855788
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940554918
I made some changes to remove unrelated changes in this PR so I will leave it to @srowen and @potiuk (who maintains the fork of cancel-workflow-runs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932994652
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143811/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] naveensrinivasan commented on a change in pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
naveensrinivasan commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r720858191
##########
File path: .github/workflows/labeler.yml
##########
@@ -31,20 +30,20 @@ jobs:
name: Label pull requests
runs-on: ubuntu-latest
steps:
- # In order to get back the negated matches like in the old config,
Review comment:
I have reverted for this one. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-933007211
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48323/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34163: [SPARK-36915] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-933012159
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48323/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932991120
Yes go ahead and create a JIRA and update the title here to include it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34163: [SPARK-36915] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r721804151
##########
File path: .github/workflows/publish_snapshot.yml
##########
@@ -35,26 +35,26 @@ jobs:
- branch-3.2
- branch-3.1
steps:
- - name: Checkout Spark repository
- uses: actions/checkout@master
- with:
- ref: ${{ matrix.branch }}
- - name: Cache Maven local repository
- uses: actions/cache@v2
- with:
- path: ~/.m2/repository
- key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
- restore-keys: |
- snapshot-maven-
- - name: Install Java 8
- uses: actions/setup-java@v1
- with:
- java-version: 8
- - name: Publish snapshot
- env:
- ASF_USERNAME: ${{ secrets.NEXUS_USER }}
- ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
- GPG_KEY: "not_used"
- GPG_PASSPHRASE: "not_used"
- GIT_REF: ${{ matrix.branch }}
- run: ./dev/create-release/release-build.sh publish-snapshot
+ - name: Checkout Spark repository
Review comment:
sorry it's a nit but let's remove these indentation changes too. I would like to backport this commit to other branches as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r724205021
##########
File path: .github/workflows/publish_snapshot.yml
##########
@@ -35,26 +35,26 @@ jobs:
- branch-3.2
- branch-3.1
steps:
- - name: Checkout Spark repository
- uses: actions/checkout@master
- with:
- ref: ${{ matrix.branch }}
- - name: Cache Maven local repository
- uses: actions/cache@v2
- with:
- path: ~/.m2/repository
- key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
- restore-keys: |
- snapshot-maven-
- - name: Install Java 8
- uses: actions/setup-java@v1
- with:
- java-version: 8
- - name: Publish snapshot
- env:
- ASF_USERNAME: ${{ secrets.NEXUS_USER }}
- ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
- GPG_KEY: "not_used"
- GPG_PASSPHRASE: "not_used"
- GIT_REF: ${{ matrix.branch }}
- run: ./dev/create-release/release-build.sh publish-snapshot
+ - name: Checkout Spark repository
Review comment:
Is one or the other indentation more correct? would it cause merge conflicts to include these?
Anyway if you don't feel strongly @naveensrinivasan could you revert these and we can get it in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940159860
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48563/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940063594
**[Test build #144085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144085/testReport)** for PR 34163 at commit [`dc8c639`](https://github.com/apache/spark/commit/dc8c6396daa84eede70b942ed70410c927ae602d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940551956
**[Test build #144108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144108/testReport)** for PR 34163 at commit [`411d813`](https://github.com/apache/spark/commit/411d813e98b3fd399b6b22778df6954f09e41119).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] naveensrinivasan commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
naveensrinivasan commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940057829
> > @naveensrinivasan are you OK to make this minor updates?
>
> Sure, I will do this in the next 2 days. Thanks for the reminder
I have addressed the changes. It should be good to merge. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940201867
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48566/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940614747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940592401
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940161193
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144085/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940587040
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940570318
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] naveensrinivasan commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
naveensrinivasan commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932989471
> Let's also file a JIRA to track these security issues (see also https://spark.apache.org/contributing.html). Otherwise, LGTM
Do you want me to create one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932873149
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143807/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r726166676
##########
File path: .github/workflows/labeler.yml
##########
@@ -22,7 +22,6 @@
# currently randomly picks any associated workflow.
# So, the name was changed to make sense in that context too.
# See also https://github.community/t/specify-check-suite-when-creating-a-checkrun/118380/10
-
Review comment:
Would you mind adding one newline back here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] naveensrinivasan commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
naveensrinivasan commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-939322902
> @naveensrinivasan are you OK to make this minor updates?
Sure, I will do this in the next 2 days. Thanks for the reminder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r726672193
##########
File path: .github/workflows/publish_snapshot.yml
##########
@@ -21,7 +21,7 @@ name: Publish Snapshot
on:
schedule:
- - cron: '0 0 * * *'
+ - cron: '0 0 * * *'
Review comment:
```suggestion
- cron: '0 0 * * *'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r724205021
##########
File path: .github/workflows/publish_snapshot.yml
##########
@@ -35,26 +35,26 @@ jobs:
- branch-3.2
- branch-3.1
steps:
- - name: Checkout Spark repository
- uses: actions/checkout@master
- with:
- ref: ${{ matrix.branch }}
- - name: Cache Maven local repository
- uses: actions/cache@v2
- with:
- path: ~/.m2/repository
- key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
- restore-keys: |
- snapshot-maven-
- - name: Install Java 8
- uses: actions/setup-java@v1
- with:
- java-version: 8
- - name: Publish snapshot
- env:
- ASF_USERNAME: ${{ secrets.NEXUS_USER }}
- ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
- GPG_KEY: "not_used"
- GPG_PASSPHRASE: "not_used"
- GIT_REF: ${{ matrix.branch }}
- run: ./dev/create-release/release-build.sh publish-snapshot
+ - name: Checkout Spark repository
Review comment:
Is one or the other indentation more correct? would it cause merge conflicts to include these?
Anyway if you don't feel strongly @naveensrinivasan could you revert these and we can get it in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940154591
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48563/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-939301025
@naveensrinivasan are you OK to make this minor updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] naveensrinivasan commented on a change in pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
naveensrinivasan commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r726169220
##########
File path: .github/workflows/labeler.yml
##########
@@ -22,7 +22,6 @@
# currently randomly picks any associated workflow.
# So, the name was changed to make sense in that context too.
# See also https://github.community/t/specify-check-suite-when-creating-a-checkrun/118380/10
-
Review comment:
Got it, Thanks. I have taken care of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940610995
**[Test build #144109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144109/testReport)** for PR 34163 at commit [`c30f37a`](https://github.com/apache/spark/commit/c30f37a1cc0e106f1eb3dff10ec720af6d749e48).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932782605
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932856308
**[Test build #143807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143807/testReport)** for PR 34163 at commit [`7c0f197`](https://github.com/apache/spark/commit/7c0f1973a312c4cdad75e02e757b33447d9ca921).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34163: [SPARK-36915] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-933012159
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48323/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940063594
**[Test build #144085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144085/testReport)** for PR 34163 at commit [`dc8c639`](https://github.com/apache/spark/commit/dc8c6396daa84eede70b942ed70410c927ae602d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940556787
**[Test build #144109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144109/testReport)** for PR 34163 at commit [`c30f37a`](https://github.com/apache/spark/commit/c30f37a1cc0e106f1eb3dff10ec720af6d749e48).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940551956
**[Test build #144108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144108/testReport)** for PR 34163 at commit [`411d813`](https://github.com/apache/spark/commit/411d813e98b3fd399b6b22778df6954f09e41119).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932782605
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r720761785
##########
File path: .github/workflows/labeler.yml
##########
@@ -31,20 +30,20 @@ jobs:
name: Label pull requests
runs-on: ubuntu-latest
steps:
- # In order to get back the negated matches like in the old config,
Review comment:
can we revert these indentation changes to make it easier to backport?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932856308
**[Test build #143807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143807/testReport)** for PR 34163 at commit [`7c0f197`](https://github.com/apache/spark/commit/7c0f1973a312c4cdad75e02e757b33447d9ca921).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932994638
**[Test build #143811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143811/testReport)** for PR 34163 at commit [`c411a56`](https://github.com/apache/spark/commit/c411a5645ee04b44647540f4f57c6d0a162596f0).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932993968
**[Test build #143811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143811/testReport)** for PR 34163 at commit [`c411a56`](https://github.com/apache/spark/commit/c411a5645ee04b44647540f4f57c6d0a162596f0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940159753
**[Test build #144085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144085/testReport)** for PR 34163 at commit [`dc8c639`](https://github.com/apache/spark/commit/dc8c6396daa84eede70b942ed70410c927ae602d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940556787
**[Test build #144109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144109/testReport)** for PR 34163 at commit [`c30f37a`](https://github.com/apache/spark/commit/c30f37a1cc0e106f1eb3dff10ec720af6d749e48).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-944918594
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932859580
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48319/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-932994652
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143811/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940148747
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48566/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940114616
**[Test build #144088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144088/testReport)** for PR 34163 at commit [`ad43fcf`](https://github.com/apache/spark/commit/ad43fcf2bd822d30cedd6b6ce2a87fd0f9f2c711).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34163: Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-933000540
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48323/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r726672279
##########
File path: .github/workflows/stale.yml
##########
@@ -27,16 +27,15 @@ jobs:
stale:
runs-on: ubuntu-latest
steps:
- - uses: actions/stale@v1.1.0
+ - uses: actions/stale@c201d45ef4b0ccbd3bb0616f93bae13e73d0a080 # pin@v1.1.0
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-pr-message: >
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just
a way of keeping the PR queue manageable.
- If you'd like to revive this PR, please reopen it and ask a
- committer to remove the Stale tag!
+ If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
Review comment:
```suggestion
If you'd like to revive this PR, please reopen it and ask a
committer to remove the Stale tag!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34163:
URL: https://github.com/apache/spark/pull/34163#issuecomment-940614749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org