You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/11/04 19:05:06 UTC

[GitHub] [cassandra] bschoening opened a new pull request, #1973: Cassandra 18006: Several CQLSH Completions are incomplete

bschoening opened a new pull request, #1973:
URL: https://github.com/apache/cassandra/pull/1973

   Thanks for sending a pull request! Here are some tips if you're new here:
    
    * Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
    * Be sure to keep the PR description updated to reflect all changes.
    * Write your PR title to summarize what this PR proposes.
    * If possible, provide a concise example to reproduce the issue for a faster review.
    * Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
    * If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
    
   Commit messages should follow the following format:
   
   ```
   <One sentence description, usually Jira title or CHANGES.txt summary>
   
   <Optional lengthier description (context on patch)>
   
   patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
   
   Co-authored-by: Name1 <email1>
   Co-authored-by: Name2 <email2>
   
   ```
   
   The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] bschoening commented on pull request #1973: Cassandra 18006: Several CQLSH Completions are incomplete

Posted by "bschoening (via GitHub)" <gi...@apache.org>.
bschoening commented on PR #1973:
URL: https://github.com/apache/cassandra/pull/1973#issuecomment-1577726794

   @jeffwidman done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] bschoening closed pull request #1973: Cassandra 18006: Several CQLSH Completions are incomplete

Posted by "bschoening (via GitHub)" <gi...@apache.org>.
bschoening closed pull request #1973: Cassandra 18006: Several CQLSH Completions are incomplete
URL: https://github.com/apache/cassandra/pull/1973


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] bschoening commented on pull request #1973: Cassandra 18006: Several CQLSH Completions are incomplete

Posted by GitBox <gi...@apache.org>.
bschoening commented on PR #1973:
URL: https://github.com/apache/cassandra/pull/1973#issuecomment-1371413472

   Yeah, that's inconsistent.  Jira 18006 was closed as a duplicate, however.
   It looks like this PR just wasn't closed.
   
   Btw, I'd like to upgrade CQLSH from optparse to argparse, but I've tried
   twice and the code is just too convoluted for me to figure it out thus far.
   
   On Wed, Jan 4, 2023 at 3:30 PM Jeff Widman ***@***.***> wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In pylib/cqlshlib/cqlshhandling.py
   > <https://github.com/apache/cassandra/pull/1973#discussion_r1061858463>:
   >
   > > @@ -141,7 +141,7 @@ def registrator(f):
   >  '''
   >
   >  cqlsh_capture_cmd_syntax_rules = r'''
   > -<captureCommand> ::= "CAPTURE" ( fname=( <stringLiteral> | "OFF" ) )?
   > +<captureCommand> ::= "CAPTURE" ( fname=( <stringLiteral>) | "OFF" )?
   >
   > The spaces between parens are inconsistent here: ( <stringLiteral>)
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/cassandra/pull/1973#pullrequestreview-1236442070>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ABMHGVELXC46JLBSOYGAEZ3WQXMVRANCNFSM6AAAAAARXPBHSI>
   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] jeffwidman commented on a diff in pull request #1973: Cassandra 18006: Several CQLSH Completions are incomplete

Posted by GitBox <gi...@apache.org>.
jeffwidman commented on code in PR #1973:
URL: https://github.com/apache/cassandra/pull/1973#discussion_r1061858463


##########
pylib/cqlshlib/cqlshhandling.py:
##########
@@ -141,7 +141,7 @@ def registrator(f):
 '''
 
 cqlsh_capture_cmd_syntax_rules = r'''
-<captureCommand> ::= "CAPTURE" ( fname=( <stringLiteral> | "OFF" ) )?
+<captureCommand> ::= "CAPTURE" ( fname=( <stringLiteral>) | "OFF" )?

Review Comment:
   The spaces between parens are inconsistent here: `( <stringLiteral>)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] jeffwidman commented on pull request #1973: Cassandra 18006: Several CQLSH Completions are incomplete

Posted by "jeffwidman (via GitHub)" <gi...@apache.org>.
jeffwidman commented on PR #1973:
URL: https://github.com/apache/cassandra/pull/1973#issuecomment-1577507347

   So @bschoening should you close this PR then? You can do that as the author of the PR... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org