You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2024/11/21 07:08:11 UTC
Re: [PR] Spark: Write DVs for V3 MoR tables [iceberg]
nastra commented on code in PR #11561:
URL: https://github.com/apache/iceberg/pull/11561#discussion_r1851471663
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java:
##########
@@ -521,7 +528,10 @@ public void deleteSingleRecordProducesDeleteOperation() throws NoSuchTableExcept
} else {
// this is a RowDelta that produces a "delete" instead of "overwrite"
validateMergeOnRead(currentSnapshot, "1", "1", null);
- validateProperty(currentSnapshot, ADD_POS_DELETE_FILES_PROP, "1");
+ TableOperations ops = ((HasTableOperations) table).operations();
Review Comment:
I don't think we need `ops` to get the version. The super class already has `formatVersion` defined, so we can just examine that field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org