Re: [PR] [#1994] improvement(netty): Add Netty support for TEZ tasks in Uniffle. [incubator-uniffle]

["zhengchenyu (via GitHub)" <gi...@apache.org>]

zhengchenyu commented on code in PR #1995:
URL: https://github.com/apache/incubator-uniffle/pull/1995#discussion_r1705057624


##########
client-tez/src/main/java/org/apache/tez/common/ShuffleAssignmentsInfoWritable.java:
##########
@@ -158,6 +143,32 @@ public void readFields(DataInput dataInput) throws IOException {
         new ShuffleAssignmentsInfo(partitionToServers, serverToPartitionRanges);
   }
 
+  private ShuffleServerInfo getShuffleServerInfo(DataInput dataInput) throws IOException {
+    ShuffleServerInfo shuffleServerInfo;
+    String id = dataInput.readUTF();
+    String host = dataInput.readUTF();
+    int grpcPort = dataInput.readInt();
+    int nettyPort = dataInput.readInt();
+    if (nettyPort != -1) {

Review Comment:
   default port is -1, do we need check port?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org