You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2017/10/12 22:05:16 UTC

[GitHub] beam pull request #3988: [BEAM-3052] ReduceFnRunner: unconditionally set onl...

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3988

    [BEAM-3052] ReduceFnRunner: unconditionally set only GC hold and timer; AfterWatermarkStateMachine: always set EOW timer

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam on-time-gc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3988.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3988
    
----
commit db17a188ab98379e2985d01e63eaa2c4bb5893fd
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-10-12T20:38:27Z

    Set end-of-window timer in AfterWatermarkStateMachine

commit 7a56ed88851688e270c868601dd24be8b2a4e12b
Author: Kenneth Knowles <kl...@google.com>
Date:   2017-09-22T22:57:01Z

    Set garbage collection timer and watermark hold unconditionally

----


---

[GitHub] beam pull request #3988: [BEAM-3052] ReduceFnRunner: Do not manage EOW hold ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3988


---