[jira] [Commented] (HBASE-10815) Master regionserver should be rolling-upgradable

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951575#comment-13951575 ] 

stack commented on HBASE-10815:
-------------------------------

We are unable to add a new connector to listen on another port to our infoserver instance?  e.g. http://stackoverflow.com/questions/6905098/how-to-configure-jetty-to-listen-to-multiple-ports  Can we not add this connector:

{code}
+    masterJettyServer.addConnector(connector);
{code}

to the existing instance?

Add this to hbase-default.xml I'd say and to the release notes "hbase.master.infoserver.redirect".  Turn it off in tests?

This is good: +    masterJettyServer.setStopAtShutdown(true);

Is it turned off for tests?

This is good too:

-          conf.getInt("hbase.regionservers", 1), LocalHMaster.class, HRegionServer.class);
+          conf.getInt("hbase.regionservers", 0), LocalHMaster.class, HRegionServer.class);



I'd think that this would be true by default?

+    usingBackupMasters = conf.getBoolean("hbase.balancer.use-backupmaster", false);

...and is the new master server on by default?  I'd hope so.

Is this right?

+    if (st == null || usingBackupMasters) return;

We return if we are using backup masters?... or am I misreading what    public void setClusterStatus(ClusterStatus st) { is about?

What is happening here?

     masterServerName = masterServices.getServerName();
+    excludedServers.remove(masterServerName);

What will the default set up be after this patch goes in?  backup masters are used r not?  master regionserver will be up by default or not?

Should we be getting this from zk?

+    int masterInfoPort = conf.getInt(HConstants.MASTER_INFO_PORT,
+      HConstants.DEFAULT_MASTER_INFOPORT);
+    conf.setInt("hbase.master.info.port.orig", masterInfoPort);

Patch looks good.





> Master regionserver should be rolling-upgradable
> ------------------------------------------------
>
>                 Key: HBASE-10815
>                 URL: https://issues.apache.org/jira/browse/HBASE-10815
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master, Region Assignment
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.99.0
>
>         Attachments: hbase-10815.patch, hbase-10815_v2.patch
>
>
> In HBASE-10569, two things could affect the rolling-upgrade from a 0.96+ release:
> * Master doesn't have its own info server any. It shares the same info server with the regionserver. We can have a setting so that we can start two info servers, one for the master on the original port, and one for the regionserver.
> * Backup master is a regionserver now. So it could hold regions. This could affect some deployment. We can have a setting so that we can prevent backup master from serving any region.



--
This message was sent by Atlassian JIRA
(v6.2#6252)