You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org> on 2007/09/28 16:41:50 UTC
[jira] Created: (JSR301-3) JDK 1.5 Functionality
JDK 1.5 Functionality
---------------------
Key: JSR301-3
URL: https://issues.apache.org/jira/browse/JSR301-3
Project: MyFaces Portlet Bridge
Issue Type: Improvement
Affects Versions: 1.0.0-SNAPSHOT
Reporter: Scott O'Bryan
Fix For: 1.0.0-SNAPSHOT
The bridge was originally coded to the JDK1.4 standard. Since JSF1.2 requires JDK5, we should follow the JDK5 standards for speed and reliability. Most notibly:
* Specify generics wherever possible - especially in the ExternalContext implementations which use this by default
* Remove the SimpleStringBuilder class in impl and replace it's usage with StringBuilder
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSR301-3) JDK 1.5 Functionality
Posted by "Simon Lessard (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/JSR301-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531036 ]
Simon Lessard commented on JSR301-3:
------------------------------------
I can take care of that one.
> JDK 1.5 Functionality
> ---------------------
>
> Key: JSR301-3
> URL: https://issues.apache.org/jira/browse/JSR301-3
> Project: MyFaces Portlet Bridge
> Issue Type: Improvement
> Affects Versions: 1.0.0-SNAPSHOT
> Reporter: Scott O'Bryan
> Fix For: 1.0.0-SNAPSHOT
>
>
> The bridge was originally coded to the JDK1.4 standard. Since JSF1.2 requires JDK5, we should follow the JDK5 standards for speed and reliability. Most notibly:
> * Specify generics wherever possible - especially in the ExternalContext implementations which use this by default
> * Remove the SimpleStringBuilder class in impl and replace it's usage with StringBuilder
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (PORTLETBRIDGE-6) JDK 1.5
Functionality
Posted by "Simon Lessard (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543192 ]
lothian edited comment on PORTLETBRIDGE-6 at 11/16/07 12:26 PM:
----------------------------------------------------------------------
Actually I'm gonna sensor myself for 30 minutes, I forgot to look at the StringBuffer issues. Creating a new patch now.
was (Author: lothian):
Actually I'm gonna sensor myself for 30 minutes, I forgot to look on StringBuffer issues. Creating a new patch now.
> JDK 1.5 Functionality
> ---------------------
>
> Key: PORTLETBRIDGE-6
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-6
> Project: MyFaces Portlet Bridge
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.0.0-SNAPSHOT
> Reporter: Scott O'Bryan
> Assignee: Simon Lessard
> Attachments: PORTLETBRIDGE-6.patch
>
>
> The bridge was originally coded to the JDK1.4 standard. Since JSF1.2 requires JDK5, we should follow the JDK5 standards for speed and reliability. Most notibly:
> * Specify generics wherever possible - especially in the ExternalContext implementations which use this by default
> * Remove the SimpleStringBuilder class in impl and replace it's usage with StringBuilder
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PORTLETBRIDGE-6) JDK 1.5 Functionality
Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott O'Bryan resolved PORTLETBRIDGE-6.
---------------------------------------
Resolution: Fixed
Hey Simon, I fixed the few issues you had and added a couple more small optimization (including replacing uses of Vector with a List). That patch was very complete and very well done. Thanks...
> JDK 1.5 Functionality
> ---------------------
>
> Key: PORTLETBRIDGE-6
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-6
> Project: MyFaces Portlet Bridge
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.0.0-SNAPSHOT
> Reporter: Scott O'Bryan
> Assignee: Simon Lessard
> Attachments: PORTLETBRIDGE-6.patch
>
>
> The bridge was originally coded to the JDK1.4 standard. Since JSF1.2 requires JDK5, we should follow the JDK5 standards for speed and reliability. Most notibly:
> * Specify generics wherever possible - especially in the ExternalContext implementations which use this by default
> * Remove the SimpleStringBuilder class in impl and replace it's usage with StringBuilder
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PORTLETBRIDGE-6) JDK 1.5 Functionality
Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544123 ]
Scott O'Bryan commented on PORTLETBRIDGE-6:
-------------------------------------------
BTW- I also checked it in for you. Thanks for letting me take a look at it.
> JDK 1.5 Functionality
> ---------------------
>
> Key: PORTLETBRIDGE-6
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-6
> Project: MyFaces Portlet Bridge
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.0.0-SNAPSHOT
> Reporter: Scott O'Bryan
> Assignee: Simon Lessard
> Fix For: 1.0.0-SNAPSHOT
>
> Attachments: PORTLETBRIDGE-6.patch
>
>
> The bridge was originally coded to the JDK1.4 standard. Since JSF1.2 requires JDK5, we should follow the JDK5 standards for speed and reliability. Most notibly:
> * Specify generics wherever possible - especially in the ExternalContext implementations which use this by default
> * Remove the SimpleStringBuilder class in impl and replace it's usage with StringBuilder
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PORTLETBRIDGE-6) JDK 1.5 Functionality
Posted by "Simon Lessard (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543192 ]
Simon Lessard commented on PORTLETBRIDGE-6:
-------------------------------------------
Actually I'm gonna sensor myself for 30 minutes, I forgot to look on StringBuffer issues. Creating a new patch now.
> JDK 1.5 Functionality
> ---------------------
>
> Key: PORTLETBRIDGE-6
> URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-6
> Project: MyFaces Portlet Bridge
> Issue Type: Improvement
> Components: General
> Affects Versions: 1.0.0-SNAPSHOT
> Reporter: Scott O'Bryan
> Assignee: Simon Lessard
> Attachments: PORTLETBRIDGE-6.patch
>
>
> The bridge was originally coded to the JDK1.4 standard. Since JSF1.2 requires JDK5, we should follow the JDK5 standards for speed and reliability. Most notibly:
> * Specify generics wherever possible - especially in the ExternalContext implementations which use this by default
> * Remove the SimpleStringBuilder class in impl and replace it's usage with StringBuilder
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSR301-3) JDK 1.5 Functionality
Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/JSR301-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531136 ]
Scott O'Bryan commented on JSR301-3:
------------------------------------
Simon, we should probably wait for this to get into source control (hopefully next week) I've got the coding standards patch almost done as well which will mess up a patch of this size as well.
> JDK 1.5 Functionality
> ---------------------
>
> Key: JSR301-3
> URL: https://issues.apache.org/jira/browse/JSR301-3
> Project: MyFaces Portlet Bridge
> Issue Type: Improvement
> Affects Versions: 1.0.0-SNAPSHOT
> Reporter: Scott O'Bryan
> Assignee: Simon Lessard
> Fix For: 1.0.0-SNAPSHOT
>
>
> The bridge was originally coded to the JDK1.4 standard. Since JSF1.2 requires JDK5, we should follow the JDK5 standards for speed and reliability. Most notibly:
> * Specify generics wherever possible - especially in the ExternalContext implementations which use this by default
> * Remove the SimpleStringBuilder class in impl and replace it's usage with StringBuilder
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.