You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/11/27 19:44:20 UTC
[commons-collections] branch master updated: COLLECTIONS-772 -
Provide private constructor to the Utils Collections (#195)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git
The following commit(s) were added to refs/heads/master by this push:
new d2e5675 COLLECTIONS-772 - Provide private constructor to the Utils Collections (#195)
d2e5675 is described below
commit d2e567562f8c364abcab9a094ec090229529925f
Author: Arturo Bernal <ar...@gmail.com>
AuthorDate: Fri Nov 27 20:44:11 2020 +0100
COLLECTIONS-772 - Provide private constructor to the Utils Collections (#195)
---
src/main/java/org/apache/commons/collections4/ArrayUtils.java | 6 ++++++
src/main/java/org/apache/commons/collections4/BagUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/ClosureUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/CollectionUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/ComparatorUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/EnumerationUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/FactoryUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/FluentIterable.java | 2 +-
src/main/java/org/apache/commons/collections4/IteratorUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/ListUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/MapUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/MultiMapUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/MultiSetUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/PredicateUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/QueueUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/SetUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/SplitMapUtils.java | 2 +-
src/main/java/org/apache/commons/collections4/TrieUtils.java | 2 +-
18 files changed, 23 insertions(+), 17 deletions(-)
diff --git a/src/main/java/org/apache/commons/collections4/ArrayUtils.java b/src/main/java/org/apache/commons/collections4/ArrayUtils.java
index 217a757..7dd4aa9 100644
--- a/src/main/java/org/apache/commons/collections4/ArrayUtils.java
+++ b/src/main/java/org/apache/commons/collections4/ArrayUtils.java
@@ -38,6 +38,12 @@ package org.apache.commons.collections4;
*/
class ArrayUtils {
+
+ /**
+ * Don't allow instances.
+ */
+ private ArrayUtils() {}
+
/**
* The index value when an element is not found in a list or array: {@code -1}. This value is returned by methods in
* this class and can also be used in comparisons with values returned by various method from
diff --git a/src/main/java/org/apache/commons/collections4/BagUtils.java b/src/main/java/org/apache/commons/collections4/BagUtils.java
index 9b94152..325a96d 100644
--- a/src/main/java/org/apache/commons/collections4/BagUtils.java
+++ b/src/main/java/org/apache/commons/collections4/BagUtils.java
@@ -49,7 +49,7 @@ public class BagUtils {
UnmodifiableSortedBag.unmodifiableSortedBag(new TreeBag<>());
/**
- * Instantiation of BagUtils is not intended or required.
+ * Don't allow instances.
*/
private BagUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/ClosureUtils.java b/src/main/java/org/apache/commons/collections4/ClosureUtils.java
index bee5854..86ce902 100644
--- a/src/main/java/org/apache/commons/collections4/ClosureUtils.java
+++ b/src/main/java/org/apache/commons/collections4/ClosureUtils.java
@@ -61,7 +61,7 @@ import org.apache.commons.collections4.functors.WhileClosure;
public class ClosureUtils {
/**
- * This class is not normally instantiated.
+ * Don't allow instances.
*/
private ClosureUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/CollectionUtils.java b/src/main/java/org/apache/commons/collections4/CollectionUtils.java
index 4c2f416..452489b 100644
--- a/src/main/java/org/apache/commons/collections4/CollectionUtils.java
+++ b/src/main/java/org/apache/commons/collections4/CollectionUtils.java
@@ -185,7 +185,7 @@ public class CollectionUtils {
public static final Collection EMPTY_COLLECTION = Collections.emptyList();
/**
- * {@code CollectionUtils} should not normally be instantiated.
+ * Don't allow instances.
*/
private CollectionUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/ComparatorUtils.java b/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
index 1459204..262d229 100644
--- a/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
+++ b/src/main/java/org/apache/commons/collections4/ComparatorUtils.java
@@ -42,7 +42,7 @@ import org.apache.commons.collections4.comparators.TransformingComparator;
public class ComparatorUtils {
/**
- * ComparatorUtils should not normally be instantiated.
+ * Don't allow instances.
*/
private ComparatorUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/EnumerationUtils.java b/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
index 8918f67..8f31c73 100644
--- a/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
+++ b/src/main/java/org/apache/commons/collections4/EnumerationUtils.java
@@ -32,7 +32,7 @@ import org.apache.commons.collections4.iterators.IteratorIterable;
public class EnumerationUtils {
/**
- * EnumerationUtils is not normally instantiated.
+ * Don't allow instances.
*/
private EnumerationUtils() {
// no instances.
diff --git a/src/main/java/org/apache/commons/collections4/FactoryUtils.java b/src/main/java/org/apache/commons/collections4/FactoryUtils.java
index b0f3be8..0b0a0bd 100644
--- a/src/main/java/org/apache/commons/collections4/FactoryUtils.java
+++ b/src/main/java/org/apache/commons/collections4/FactoryUtils.java
@@ -44,7 +44,7 @@ import org.apache.commons.collections4.functors.PrototypeFactory;
public class FactoryUtils {
/**
- * This class is not normally instantiated.
+ * Don't allow instances.
*/
private FactoryUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/FluentIterable.java b/src/main/java/org/apache/commons/collections4/FluentIterable.java
index 53f57a9..0d1bebc 100644
--- a/src/main/java/org/apache/commons/collections4/FluentIterable.java
+++ b/src/main/java/org/apache/commons/collections4/FluentIterable.java
@@ -134,7 +134,7 @@ public class FluentIterable<E> implements Iterable<E> {
// ----------------------------------------------------------------------
/**
- * Package-private constructor, used by IterableUtils.
+ * Don't allow instances.
*/
FluentIterable() {
this.iterable = this;
diff --git a/src/main/java/org/apache/commons/collections4/IteratorUtils.java b/src/main/java/org/apache/commons/collections4/IteratorUtils.java
index d6c5283..751f4a3 100644
--- a/src/main/java/org/apache/commons/collections4/IteratorUtils.java
+++ b/src/main/java/org/apache/commons/collections4/IteratorUtils.java
@@ -123,7 +123,7 @@ public class IteratorUtils {
private static final String DEFAULT_TOSTRING_DELIMITER = ", ";
/**
- * IteratorUtils is not normally instantiated.
+ * Don't allow instances.
*/
private IteratorUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/ListUtils.java b/src/main/java/org/apache/commons/collections4/ListUtils.java
index 624beba..46d9beb 100644
--- a/src/main/java/org/apache/commons/collections4/ListUtils.java
+++ b/src/main/java/org/apache/commons/collections4/ListUtils.java
@@ -44,7 +44,7 @@ import org.apache.commons.collections4.sequence.SequencesComparator;
public class ListUtils {
/**
- * {@code ListUtils} should not normally be instantiated.
+ * Don't allow instances.
*/
private ListUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/MapUtils.java b/src/main/java/org/apache/commons/collections4/MapUtils.java
index 7298f33..a84b783 100644
--- a/src/main/java/org/apache/commons/collections4/MapUtils.java
+++ b/src/main/java/org/apache/commons/collections4/MapUtils.java
@@ -2044,7 +2044,7 @@ public class MapUtils {
}
/**
- * {@code MapUtils} should not normally be instantiated.
+ * Don't allow instances.
*/
private MapUtils() {
}
diff --git a/src/main/java/org/apache/commons/collections4/MultiMapUtils.java b/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
index 17db98f..0d701ff 100644
--- a/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
+++ b/src/main/java/org/apache/commons/collections4/MultiMapUtils.java
@@ -44,7 +44,7 @@ import org.apache.commons.collections4.multimap.UnmodifiableMultiValuedMap;
public class MultiMapUtils {
/**
- * {@code MultiMapUtils} should not normally be instantiated.
+ * Don't allow instances.
*/
private MultiMapUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/MultiSetUtils.java b/src/main/java/org/apache/commons/collections4/MultiSetUtils.java
index 9eb25b0..fa0051d 100644
--- a/src/main/java/org/apache/commons/collections4/MultiSetUtils.java
+++ b/src/main/java/org/apache/commons/collections4/MultiSetUtils.java
@@ -36,7 +36,7 @@ public class MultiSetUtils {
UnmodifiableMultiSet.unmodifiableMultiSet(new HashMultiSet<>());
/**
- * Instantiation of MultiSetUtils is not intended or required.
+ * Don't allow instances.
*/
private MultiSetUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/PredicateUtils.java b/src/main/java/org/apache/commons/collections4/PredicateUtils.java
index c381de3..fb1f3ad 100644
--- a/src/main/java/org/apache/commons/collections4/PredicateUtils.java
+++ b/src/main/java/org/apache/commons/collections4/PredicateUtils.java
@@ -71,7 +71,7 @@ import org.apache.commons.collections4.functors.UniquePredicate;
public class PredicateUtils {
/**
- * This class is not normally instantiated.
+ * Don't allow instances.
*/
private PredicateUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/QueueUtils.java b/src/main/java/org/apache/commons/collections4/QueueUtils.java
index ffcfbd4..1137727 100644
--- a/src/main/java/org/apache/commons/collections4/QueueUtils.java
+++ b/src/main/java/org/apache/commons/collections4/QueueUtils.java
@@ -38,7 +38,7 @@ public class QueueUtils {
public static final Queue EMPTY_QUEUE = UnmodifiableQueue.unmodifiableQueue(new LinkedList<>());
/**
- * {@code QueueUtils} should not normally be instantiated.
+ * Don't allow instances.
*/
private QueueUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/SetUtils.java b/src/main/java/org/apache/commons/collections4/SetUtils.java
index 49d57b3..2056db5 100644
--- a/src/main/java/org/apache/commons/collections4/SetUtils.java
+++ b/src/main/java/org/apache/commons/collections4/SetUtils.java
@@ -656,7 +656,7 @@ public class SetUtils {
}
/**
- * {@code SetUtils} should not normally be instantiated.
+ * Don't allow instances.
*/
private SetUtils() {}
}
diff --git a/src/main/java/org/apache/commons/collections4/SplitMapUtils.java b/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
index cff8dc6..2a1a9e9 100644
--- a/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
+++ b/src/main/java/org/apache/commons/collections4/SplitMapUtils.java
@@ -39,7 +39,7 @@ import org.apache.commons.collections4.set.UnmodifiableSet;
public class SplitMapUtils {
/**
- * {@code SplitMapUtils} should not normally be instantiated.
+ * Don't allow instances.
*/
private SplitMapUtils() {}
diff --git a/src/main/java/org/apache/commons/collections4/TrieUtils.java b/src/main/java/org/apache/commons/collections4/TrieUtils.java
index 3a6d038..6cb7ce3 100644
--- a/src/main/java/org/apache/commons/collections4/TrieUtils.java
+++ b/src/main/java/org/apache/commons/collections4/TrieUtils.java
@@ -26,7 +26,7 @@ import org.apache.commons.collections4.trie.UnmodifiableTrie;
public class TrieUtils {
/**
- * {@link TrieUtils} should not normally be instantiated.
+ * Don't allow instances.
*/
private TrieUtils() {}