You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "tirkarthi (via GitHub)" <gi...@apache.org> on 2025/08/19 14:01:47 UTC

[PR] Add hotkey shortcut to toggle between grid and graph views. [airflow]

tirkarthi opened a new pull request, #54667:
URL: https://github.com/apache/airflow/pull/54667

    Add <kbd>g</kbd> as hotkey shortcut key to toggle between the grid and graph view. This needs to discoverable so this can be shown along with "show grid" tooltip like "show grid (press g)" . I am not sure how translations are handled for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add hotkey shortcut to toggle between grid and graph views. [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #54667:
URL: https://github.com/apache/airflow/pull/54667


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add hotkey shortcut to toggle between grid and graph views. [airflow]

Posted by "tirkarthi (via GitHub)" <gi...@apache.org>.
tirkarthi commented on PR #54667:
URL: https://github.com/apache/airflow/pull/54667#issuecomment-3213214540

   Thanks @jscheffl , are there any guidelines for translations? There is already a tooltip with "Show Graph" which I can make it along "Show Graph (press g to switch)"  but wondering how to update the other language translations for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add hotkey shortcut to toggle between grid and graph views. [airflow]

Posted by "tirkarthi (via GitHub)" <gi...@apache.org>.
tirkarthi commented on PR #54667:
URL: https://github.com/apache/airflow/pull/54667#issuecomment-3226917866

   Thanks @jscheffl and @shahar1, I have updated the key and translation value to include the shortcut that should report a missing translation. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add hotkey shortcut to toggle between grid and graph views. [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #54667:
URL: https://github.com/apache/airflow/pull/54667#issuecomment-3215412423

   > Thanks @jscheffl , are there any guidelines for translations? There is already a tooltip with "Show Graph" which I can make it along "Show Graph (press g to switch)" but wondering how to update the other language translations for this.
   
   We had a description on this in https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/ui/public/i18n/README.md#55-adding-or-rephrasing-terms - but with current tooling it is hard to see what base language has changed in term. @shahar1 do you have any proposal? My proposal would be to delete the key and create a new / different one to force adjustment of translation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add hotkey shortcut to toggle between grid and graph views. [airflow]

Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #54667:
URL: https://github.com/apache/airflow/pull/54667#issuecomment-3215430873

   > > Thanks @jscheffl , are there any guidelines for translations? There is already a tooltip with "Show Graph" which I can make it along "Show Graph (press g to switch)" but wondering how to update the other language translations for this.
   > 
   > We had a description on this in https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/ui/public/i18n/README.md#55-adding-or-rephrasing-terms - but with current tooling it is hard to see what base language has changed in term. @shahar1 do you have any proposal? My proposal would be to delete the key and create a new / different one to force adjustment of translation.
   
   I'd probably go for something like this as well :)
   It is probably worth mentioning in the policy as well for future reference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org