You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fury.apache.org by "An-DJ (via GitHub)" <gi...@apache.org> on 2024/10/14 16:13:23 UTC
[PR] feat(ci): support building python on windows [fury]
An-DJ opened a new pull request, #1885:
URL: https://github.com/apache/fury/pull/1885
<!--
**Thanks for contributing to Fury.**
**If this is your first time opening a PR on fury, you can refer to [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).**
Contribution Checklist
- The **Apache Fury (incubating)** community has restrictions on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fury/blob/main/CONTRIBUTING.md).
- Fury has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here.
-->
## What does this PR do?
Support building python on Windows.
## Related issues
<!--
Is there any related issue? Please attach here.
- #xxxx0
- #xxxx1
- #xxxx2
-->
## Does this PR introduce any user-facing change?
<!--
If any user-facing interface changes, please [open an issue](https://github.com/apache/fury/issues/new/choose) describing the need to do so and update the document if necessary.
-->
- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?
## Benchmark
<!--
When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1921997499
##########
.python-version:
##########
@@ -0,0 +1 @@
+3.11.0
Review Comment:
is this committed to repo by accident?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1883696925
##########
cpp/fury/util/logging.h:
##########
@@ -35,7 +35,7 @@ enum class FuryLogLevel {
DEBUG = -1,
INFO = 0,
WARNING = 1,
- ERROR = 2,
+ ERR = 2,
Review Comment:
> Rename FuryLogLevel::ERROR to FuryLogLevel::ERR. I don't know why this enum make build failed, but it is successed if renaming it to FuryLogLevel::ERR
Could you attach the error message/log you face about the original `ERROR` identifier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1922599341
##########
python/pyfury/_util.pyx:
##########
@@ -29,10 +29,13 @@ from libcpp cimport bool as c_bool
from pyfury.includes.libutil cimport(
CBuffer, AllocateBuffer, GetBit, SetBit, ClearBit, SetBitTo, CStatus, StatusCode, utf16HasSurrogatePairs
)
+import os
cdef int32_t max_buffer_size = 2 ** 31 - 1
cdef int UTF16_LE = -1
+_WINDOWS = os.name == 'nt'
Review Comment:
```suggestion
cdef c_bool _WINDOWS = os.name == 'nt'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on PR #1885:
URL: https://github.com/apache/fury/pull/1885#issuecomment-2601319336
Hi @chaokunyang
There is a friendly github action that could simplify the bazel installization. ⬇️
https://github.com/marketplace/actions/setup-bazel-environment
But I found that the Apache organization manages a allowed action namelist.
Could you plz add that action to the namelist? Then we can easily install bazel 6.3.2 on Windows.
Ref:
https://docs.github.com/en/organizations/managing-organization-settings/disabling-or-limiting-github-actions-for-your-organization#allowing-select-actions-and-reusable-workflows-to-run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on PR #1885:
URL: https://github.com/apache/fury/pull/1885#issuecomment-2453037302
@chaokunyang This UT is strange.
```
@pytest.mark.parametrize("language", [Language.XLANG, Language.PYTHON])
def test_array_serializer(language):
fury = Fury(language=language, ref_tracking=True, require_class_registration=False)
for typecode in PyArraySerializer.typecode_dict.keys():
arr = array.array(typecode, list(range(10)))
# additional code to print array attribute
print(arr.itemsize, arr.typecode)
# end
assert ser_de(fury, arr) == arr
for dtype in Numpy1DArraySerializer.dtypes_dict.keys():
arr = np.array(list(range(10)), dtype=dtype)
new_arr = ser_de(fury, arr)
assert np.array_equal(new_arr, arr)
np.testing.assert_array_equal(new_arr, arr)
```
I test it on Ubuntu 20.04 and Windows 10, but there are different result:
```
# Ubuntu
pyfury/tests/test_serializer.py::test_array_serializer[Language.XLANG] 2 h
4 i
8 l
4 f
8 d
PASSED
pyfury/tests/test_serializer.py::test_array_serializer[Language.PYTHON] 2 h
4 i
8 l
4 f
8 d
PASSED
```
```
# Windows
=================== 1 failed, 1 passed, 3 warnings in 0.88s ===================
FAILED [ 50%]
2 h
4 i
4 l
```
The point is that `l` type could be 4 or 8 bit on different platform.
In addition, in `_util.pyx`, there are also failed converted between `const int64_t` and `long`:
```
cdef inline uint8_t* get_address(v):
view = memoryview(v)
cdef str dtype = view.format
cdef:
# ...
const int64_t[:] signed_long_data
# ...
uint8_t* ptr
if dtype == "b":
signed_char_data = v
ptr = <uint8_t*>(&signed_char_data[0])
elif dtype == "l": # here
signed_long_data = v
ptr = <uint8_t*>(&signed_long_data[0])
else:
raise Exception(f"Unsupported buffer of type {type(v)} and format {dtype}")
return ptr
```
Could you plz give me some advice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on PR #1885:
URL: https://github.com/apache/fury/pull/1885#issuecomment-2453250634
> Is Windows a big endian machine?
You means the github windows-2022 ci runner is hosted on a big endian machine?
No. According to the [related document](https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#cloud-hosts-for-github-hosted-runners), for Linux and Windows runners, GitHub uses Dadsv5-series virtual machines. For more information, see [Dasv5 and Dadsv5-series](https://learn.microsoft.com/en-us/azure/virtual-machines/dasv5-dadsv5-series#dadsv5-series) in the Microsoft Azure documentation.
`AMD EPYC 7763v (Genoa) [x86-64]` support small endian only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1883712235
##########
cpp/fury/util/logging.h:
##########
@@ -35,7 +35,7 @@ enum class FuryLogLevel {
DEBUG = -1,
INFO = 0,
WARNING = 1,
- ERROR = 2,
+ ERR = 2,
Review Comment:
Just took a glance, and I think that maybe the Cython generated code defines a macro named `ERROR` and it's included before this header so that weird thing happens. Not familiar with related code here, maybe @penguin-wwy has ideas about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on PR #1885:
URL: https://github.com/apache/fury/pull/1885#issuecomment-2537665188
Hi @chaokunyang
Recently I have searched and found that windows(MSVC) standards basic [data type range](https://learn.microsoft.com/en-us/cpp/cpp/data-type-ranges?view=msvc-170). Also in [intel docs](https://www.intel.com/content/www/us/en/developer/articles/technical/size-of-long-integer-type-on-different-architecture-and-os.html).
Unfortunately, `long`, which used as `l` in Python, is stricted in 4 bytes on Windows, but 8 bytes on *nix. That is a gap between *nix and Windows.
So Apache Fury support `q` (in another words, `signed long long`) ONLY maybe a better choice. That type is 8 bytes size in both *nix and Windows.
I am not fimilair with Python array.array() users' habit, but this approach could be a simple solution to universe the memory model in Apache Fury Python support.
What do you think of that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #1885:
URL: https://github.com/apache/fury/pull/1885#issuecomment-2539534892
> Great idea, I think we can use `q (signed long long)` instead of `l`. And raise Error when `l` array format type are passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1883696925
##########
cpp/fury/util/logging.h:
##########
@@ -35,7 +35,7 @@ enum class FuryLogLevel {
DEBUG = -1,
INFO = 0,
WARNING = 1,
- ERROR = 2,
+ ERR = 2,
Review Comment:
Could you attach the error you face of the original `ERROR` identifier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1922178528
##########
.python-version:
##########
@@ -0,0 +1 @@
+3.11.0
Review Comment:
> is this committed to repo by accident?
Deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1883701555
##########
cpp/fury/util/logging.h:
##########
@@ -35,7 +35,7 @@ enum class FuryLogLevel {
DEBUG = -1,
INFO = 0,
WARNING = 1,
- ERROR = 2,
+ ERR = 2,
Review Comment:
Hmm it seems here: https://github.com/apache/fury/actions/runs/11643078405/job/32423399925#step:5:1894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #1885:
URL: https://github.com/apache/fury/pull/1885#issuecomment-2428366827
Hi @An-DJ , it this PR ready for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1883696925
##########
cpp/fury/util/logging.h:
##########
@@ -35,7 +35,7 @@ enum class FuryLogLevel {
DEBUG = -1,
INFO = 0,
WARNING = 1,
- ERROR = 2,
+ ERR = 2,
Review Comment:
Could you attach the error message/log you face about the original `ERROR` identifier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #1885:
URL: https://github.com/apache/fury/pull/1885#issuecomment-2453040540
Is Windows a bid endian machine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on PR #1885:
URL: https://github.com/apache/fury/pull/1885#issuecomment-2448870734
> Hi @An-DJ , it this PR ready for review?
No, CI result is fake, the build script didn't have been executed successfully. We need more works on windows platform...
I will continue this PR in the next few days (too busy in this week...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1922598166
##########
cpp/fury/util/logging.h:
##########
@@ -35,7 +35,7 @@ enum class FuryLogLevel {
DEBUG = -1,
INFO = 0,
WARNING = 1,
- ERROR = 2,
+ ERR = 2,
Review Comment:
from chatgpt:
MSVC and Macros: The MSVC environment automatically defines some macros that can interfere with your code. One such macro is ERROR, which is commonly defined within Windows headers or other libraries. When you use ERROR as a name for an enumeration or variable in your code, it collides with this pre-existing macro definition, causing syntax errors.
We can use ERR here, for better compatibility, maybe we should define the enum value with FURY prefix:
```c++
enum class FuryLogLevel {
FURY_DEBUG = -1,
FURY_INFO = 0,
FURY_WARNING = 1,
FURY_ERROR = 2,
FURY_FATAL = 3
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on PR #1885:
URL: https://github.com/apache/fury/pull/1885#issuecomment-2453282477
@chaokunyang Actually we check the python array initialization method `array.array` with different dtype, but each type code has its `Mininum size in bytes`, not a fixed size.
IMHO it is the reason why it behaves differently on UNIX and Windows.
Ref: https://docs.python.org/3/library/array.html
We should find a strict way to fix each dtype size... right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #1885:
URL: https://github.com/apache/fury/pull/1885#issuecomment-2453436698
Yeah, you are right. Fury take `l` as 4 bytes, but it may be 8 bytes on windows. In such cases, we may need to expand every item from 4 bytes value to 8 bytes in a loop manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #1885:
URL: https://github.com/apache/fury/pull/1885#issuecomment-2539532350
Great idea, I think we can use `q (signed long long)` instead of `l`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1883696925
##########
cpp/fury/util/logging.h:
##########
@@ -35,7 +35,7 @@ enum class FuryLogLevel {
DEBUG = -1,
INFO = 0,
WARNING = 1,
- ERROR = 2,
+ ERR = 2,
Review Comment:
Could you attach the error you face about the original `ERROR` identifier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on code in PR #1885:
URL: https://github.com/apache/fury/pull/1885#discussion_r1923032947
##########
cpp/fury/util/logging.h:
##########
@@ -35,7 +35,7 @@ enum class FuryLogLevel {
DEBUG = -1,
INFO = 0,
WARNING = 1,
- ERROR = 2,
+ ERR = 2,
Review Comment:
Good idea. Restyle it in #2016 . : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(ci): support building python on windows [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang merged PR #1885:
URL: https://github.com/apache/fury/pull/1885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org