[GitHub] [apisix] spacewander commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

["spacewander (via GitHub)" <gi...@apache.org>]

spacewander commented on code in PR #8824:
URL: https://github.com/apache/apisix/pull/8824#discussion_r1112451480


##########
apisix/core/request.lua:
##########
@@ -143,14 +143,35 @@ function _M.set_header(ctx, header_name, header_value)
     end
 end
 
-function _M.add_header(header_name, header_value)
+function _M.add_header(ctx, header_name, header_value)

Review Comment:
   The names follow the corresponding API in OpenResty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org