You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/09/26 23:17:14 UTC
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14314
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/ImpalaVariables.xml
M docs/topics/impala_client.xml
A docs/topics/impala_fetch_rows_timeout_ms.xml
A docs/topics/impala_max_result_spooling_mem.xml
A docs/topics/impala_max_spilled_result_spooling_mem.xml
A docs/topics/impala_query_results_spooling.xml
A docs/topics/impala_spool_query_results.xml
9 files changed, 400 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/14314/1
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 1:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml
File docs/topics/impala_fetch_rows_timeout_ms.xml:
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@21
PS1, Line 21: IMPALA-3200
is this the right JIRA?
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@46
PS1, Line 46: </p>
should mention IMPALA-8962 as well. the timeout also applies to fetch request issued against 'RUNNING' queries. a query that is 'RUNNING' has no rows available, so any fetch request will wait until the query transitions to the 'FINISHED' state and for it to fetch all requested rows. a query in the 'FINISHED' state means that the rows are available to be fetched (the query may actually still be executing though).
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@51
PS1, Line 51: 10
default is 10 seconds, so 10000 ms, should the units be somewhere?
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_result_spooling_mem.xml
File docs/topics/impala_max_result_spooling_mem.xml:
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_result_spooling_mem.xml@39
PS1, Line 39: unpinned
I don't think our docs really explain the difference between unpinned vs pinned memory, so we should probably avoid mentioning pinned and unpinned memory altogether.
for this section, we can just say that all memory will most likely be spilled to disk.
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_spilled_result_spooling_mem.xml
File docs/topics/impala_max_spilled_result_spooling_mem.xml:
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_spilled_result_spooling_mem.xml@47
PS1, Line 47: to allow unpinning all pinned
: memory when the amount of spooled results exceeds
: <codeph>MAX_RESULT_SPOOLING_MEM</codeph>
can just remove this part
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml
File docs/topics/impala_query_results_spooling.xml:
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@32
PS1, Line 32: cause
causing
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@32
PS1, Line 32: wait for
: extended
wait for an extended
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@40
PS1, Line 40: this spooled locations
the spooled results.
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@54
PS1, Line 54: unpinned
remove unpin reference here and below
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@95
PS1, Line 95: of the number of rows returned by the query
of the amount of memory needed to spool all the rows returned by the query
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@98
PS1, Line 98: and
remove "and". the read and write buffers are 2 MB in size each, which is why the default is 4 MB
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@117
PS1, Line 117: asynchronously
remove, it isn't really asynchronously
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 00:12:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml
File docs/topics/impala_fetch_rows_timeout_ms.xml:
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@46
PS1, Line 46: </p>
> Do users need this (implementation) detail?
I think it should be documented, it is potentially impactful for any users who have written their own client code to interact with Impala.
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml
File docs/topics/impala_fetch_rows_timeout_ms.xml:
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@40
PS3, Line 40: TRUE
should be false
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@43
PS3, Line 43: FALSE
should be true
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@47
PS3, Line 47: Only positive values are allowed
sorry, just fixed a bug with this and now a value of 0 for FETCH_ROWS_TIMEOUT_MS means that fetch requests wait indefinitely (essentially what the old behavior would do).
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml
File docs/topics/impala_query_results_spooling.xml:
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@43
PS3, Line 43: POOL_QUERY_RESULTS
SPOOL_QUERY_RESULTS
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@78
PS3, Line 78: TRUE
FALSE
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@81
PS3, Line 81: FALSE
TRUE
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_spool_query_results.xml
File docs/topics/impala_spool_query_results.xml:
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_spool_query_results.xml@36
PS3, Line 36: <p>Use the <codeph>SPOOL_QUERY_RESULTS</codeph> query option to enable query
: result spooling, which is disabled by default.</p>
: <p>Query result spooling controls how rows are returned to the client. <ul>
: <li>When query result spooling is disabled, Impala relies on clients to
: fetch results to trigger the generation of more result row batches
: until all the result rows have been produced. If a client issues a
: query without fetching all the results, the query fragments will
: continue to consume the resources until the query is cancelled and
: unregistered, potentially tying up resources and cause other queries
: to wait for extended period of time in admission control.</li>
: <li>When query result spooling is enabled, result sets of queries are
: eagerly fetched and spooled in the spooling location on a persistent
: storage, either in memory or on disk. <p>Once all result rows have
: been fetched and stored in the spooling location, the resources are
: freed up. Incoming client fetches can get the data from this spooled
: locations.</p></li>
: </ul></p>
I think some of the review comments from impala_query_results_spooling.xml need to be re-applied here.
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 22:04:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/497/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 18:10:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 4: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/500/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 23:07:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/496/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Sep 2019 23:33:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 4:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/500/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 22:44:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Reviewed-on: http://gerrit.cloudera.org:8080/14314
Reviewed-by: Sahil Takiar <st...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/ImpalaVariables.xml
M docs/topics/impala_client.xml
A docs/topics/impala_fetch_rows_timeout_ms.xml
A docs/topics/impala_max_result_spooling_mem.xml
A docs/topics/impala_max_spilled_result_spooling_mem.xml
A docs/topics/impala_query_results_spooling.xml
A docs/topics/impala_spool_query_results.xml
9 files changed, 405 insertions(+), 6 deletions(-)
Approvals:
Sahil Takiar: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Sahil Takiar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14314
to look at the new patch set (#4).
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/ImpalaVariables.xml
M docs/topics/impala_client.xml
A docs/topics/impala_fetch_rows_timeout_ms.xml
A docs/topics/impala_max_result_spooling_mem.xml
A docs/topics/impala_max_spilled_result_spooling_mem.xml
A docs/topics/impala_query_results_spooling.xml
A docs/topics/impala_spool_query_results.xml
9 files changed, 405 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/14314/4
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 5: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/506/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Oct 2019 23:30:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Minor comments, otherwise LGTM.
http://gerrit.cloudera.org:8080/#/c/14314/4/docs/topics/impala_spool_query_results.xml
File docs/topics/impala_spool_query_results.xml:
http://gerrit.cloudera.org:8080/#/c/14314/4/docs/topics/impala_spool_query_results.xml@49
PS4, Line 49: on a persistent storage,
delete this, memory is not persistent
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Oct 2019 22:15:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/497/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 18:19:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Sahil Takiar, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14314
to look at the new patch set (#5).
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/ImpalaVariables.xml
M docs/topics/impala_client.xml
A docs/topics/impala_fetch_rows_timeout_ms.xml
A docs/topics/impala_max_result_spooling_mem.xml
A docs/topics/impala_max_spilled_result_spooling_mem.xml
A docs/topics/impala_query_results_spooling.xml
A docs/topics/impala_spool_query_results.xml
9 files changed, 405 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/14314/5
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14314/4/docs/topics/impala_spool_query_results.xml
File docs/topics/impala_spool_query_results.xml:
http://gerrit.cloudera.org:8080/#/c/14314/4/docs/topics/impala_spool_query_results.xml@49
PS4, Line 49: on a persistent storage,
> delete this, memory is not persistent
Done
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Oct 2019 23:12:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/498/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 18:13:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 3:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml
File docs/topics/impala_fetch_rows_timeout_ms.xml:
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@46
PS1, Line 46: </p>
> I think it should be documented, it is potentially impactful for any users
Done
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@51
PS1, Line 51: 10
> The query option has "MS" in the name, implying the unit. I added "10 Secon
Done
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml
File docs/topics/impala_fetch_rows_timeout_ms.xml:
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@40
PS3, Line 40: TRUE
> should be false
Done
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@43
PS3, Line 43: FALSE
> should be true
Done
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_fetch_rows_timeout_ms.xml@47
PS3, Line 47: Only positive values are allowed
> sorry, just fixed a bug with this and now a value of 0 for FETCH_ROWS_TIMEO
Done
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml
File docs/topics/impala_query_results_spooling.xml:
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@43
PS3, Line 43: POOL_QUERY_RESULTS
> SPOOL_QUERY_RESULTS
Done
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@78
PS3, Line 78: TRUE
> FALSE
Done
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_query_results_spooling.xml@81
PS3, Line 81: FALSE
> TRUE
Done
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_spool_query_results.xml
File docs/topics/impala_spool_query_results.xml:
http://gerrit.cloudera.org:8080/#/c/14314/3/docs/topics/impala_spool_query_results.xml@36
PS3, Line 36: <p>Use the <codeph>SPOOL_QUERY_RESULTS</codeph> query option to enable query
: result spooling, which is disabled by default.</p>
: <p>Query result spooling controls how rows are returned to the client. <ul>
: <li>When query result spooling is disabled, Impala relies on clients to
: fetch results to trigger the generation of more result row batches
: until all the result rows have been produced. If a client issues a
: query without fetching all the results, the query fragments will
: continue to consume the resources until the query is cancelled and
: unregistered, potentially tying up resources and cause other queries
: to wait for extended period of time in admission control.</li>
: <li>When query result spooling is enabled, result sets of queries are
: eagerly fetched and spooled in the spooling location on a persistent
: storage, either in memory or on disk. <p>Once all result rows have
: been fetched and stored in the spooling location, the resources are
: freed up. Incoming client fetches can get the data from this spooled
: locations.</p></li>
: </ul></p>
> I think some of the review comments from impala_query_results_spooling.xml
attempted
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 22:42:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 1:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml
File docs/topics/impala_fetch_rows_timeout_ms.xml:
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@21
PS1, Line 21: IMPALA-3200
> is this the right JIRA?
No, removed.
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@46
PS1, Line 46: </p>
> should mention IMPALA-8962 as well. the timeout also applies to fetch reque
Do users need this (implementation) detail?
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_fetch_rows_timeout_ms.xml@51
PS1, Line 51: 10
> default is 10 seconds, so 10000 ms, should the units be somewhere?
The query option has "MS" in the name, implying the unit. I added "10 Seconds" to be extra clear.
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_result_spooling_mem.xml
File docs/topics/impala_max_result_spooling_mem.xml:
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_result_spooling_mem.xml@39
PS1, Line 39: unpinned
> I don't think our docs really explain the difference between unpinned vs pi
Done
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_spilled_result_spooling_mem.xml
File docs/topics/impala_max_spilled_result_spooling_mem.xml:
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_max_spilled_result_spooling_mem.xml@47
PS1, Line 47: to allow unpinning all pinned
: memory when the amount of spooled results exceeds
: <codeph>MAX_RESULT_SPOOLING_MEM</codeph>
> can just remove this part
Done
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml
File docs/topics/impala_query_results_spooling.xml:
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@32
PS1, Line 32: cause
> causing
Done
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@32
PS1, Line 32: wait for
: extended
> wait for an extended
Done
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@40
PS1, Line 40: this spooled locations
> the spooled results.
Done
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@54
PS1, Line 54: unpinned
> remove unpin reference here and below
Done
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@95
PS1, Line 95: of the number of rows returned by the query
> of the amount of memory needed to spool all the rows returned by the query
Done
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@98
PS1, Line 98: and
> remove "and". the read and write buffers are 2 MB in size each, which is wh
Done
http://gerrit.cloudera.org:8080/#/c/14314/1/docs/topics/impala_query_results_spooling.xml@117
PS1, Line 117: asynchronously
> remove, it isn't really asynchronously
Done
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 18:08:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Oct 2019 23:28:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/498/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 19:08:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Sahil Takiar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14314
to look at the new patch set (#3).
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/ImpalaVariables.xml
M docs/topics/impala_client.xml
A docs/topics/impala_fetch_rows_timeout_ms.xml
A docs/topics/impala_max_result_spooling_mem.xml
A docs/topics/impala_max_spilled_result_spooling_mem.xml
A docs/topics/impala_query_results_spooling.xml
A docs/topics/impala_spool_query_results.xml
9 files changed, 398 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/14314/3
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/496/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Sep 2019 23:17:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14314 )
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
Patch Set 5:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/506/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Oct 2019 23:13:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8826: [DOCS] Add docs for PLAN ROOT SINK and result spooling
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Sahil Takiar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14314
to look at the new patch set (#2).
Change subject: IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
......................................................................
IMPALA-8826: [DOCS] Add docs for PLAN_ROOT_SINK and result spooling
Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/ImpalaVariables.xml
M docs/topics/impala_client.xml
A docs/topics/impala_fetch_rows_timeout_ms.xml
A docs/topics/impala_max_result_spooling_mem.xml
A docs/topics/impala_max_spilled_result_spooling_mem.xml
A docs/topics/impala_query_results_spooling.xml
A docs/topics/impala_spool_query_results.xml
9 files changed, 398 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/14314/2
--
To view, visit http://gerrit.cloudera.org:8080/14314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78bfceb225d25078c54c1ed8f88ca250ef42dafe
Gerrit-Change-Number: 14314
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>