[GitHub] gianm commented on a change in pull request #6215: Adding licenses and enable apache-rat-plugin.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6215: Adding licenses and enable apache-rat-plugin.
URL: https://github.com/apache/incubator-druid/pull/6215#discussion_r212157067
 
 

 ##########
 File path: examples/quickstart/tutorial/hadoop/docker/Dockerfile
 ##########
 @@ -1,3 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
 
 Review comment:
   This comes from https://github.com/sequenceiq/hadoop-docker so the header here is probably not right. That is a third party work (https://www.apache.org/legal/src-headers.html#3party). The original file didn't have a license header, but it was distributed along with an Apache 2.0 LICENSE file, so I think it's clear that the original file is Apache licensed.
   
   I don't see a clear policy about what to do here, but maybe a header like this will get the point across. It's the non-ASF version of the Apache 2.0 header with an extra sentence at the top.
   
   ```
   # Based on the SequenceIQ hadoop-docker project hosted at
   # https://github.com/sequenceiq/hadoop-docker, and modified at
   # the Apache Software Foundation (ASF).
   #
   # Licensed under the Apache License, Version 2.0 (the "License");
   # you may not use this file except in compliance with the License.
   # You may obtain a copy of the License at
   # 
   #     http://www.apache.org/licenses/LICENSE-2.0
   # 
   # Unless required by applicable law or agreed to in writing, software
   # distributed under the License is distributed on an "AS IS" BASIS,
   # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   # See the License for the specific language governing permissions and
   # limitations under the License.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org