[GitHub] [activemq] gemmellr commented on a change in pull request #754: AMQ-8472 - Switch to reload4j for logging

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #754:
URL: https://github.com/apache/activemq/pull/754#discussion_r800054034



##########
File path: activemq-karaf/pom.xml
##########
@@ -42,12 +42,12 @@
     <dependency>
       <groupId>org.ops4j.pax.logging</groupId>
       <artifactId>pax-logging-api</artifactId>
-      <version>1.11.4</version>
+      <version>1.11.14</version>

Review comment:
       Should probably add a property for this, perhaps dependencyManagement, to keep it consistent (I see from the dependency:trree there are a few different pax-logging versions in use in different modules).

##########
File path: activemq-all/pom.xml
##########
@@ -14,7 +14,7 @@
   <parent>
     <groupId>org.apache.activemq</groupId>
     <artifactId>activemq-parent</artifactId>
-    <version>5.16.4-SNAPSHOT</version>
+    <version>5.16.5-SNAPSHOT</version>

Review comment:
       PR needs rebased to remove the release commits deleted from the branch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org