You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/29 06:51:42 UTC
[GitHub] [incubator-nuttx] pussuw opened a new pull request, #6176: UMM: Implement getter for address environment heap start vaddr
pussuw opened a new pull request, #6176:
URL: https://github.com/apache/incubator-nuttx/pull/6176
Using the Kconfig macro does not work for RISC-V target, as there the
user heap follows .data/.bss and does not obey any Kconfig provided
boundary.
Added stubs for ARM and Z80 also.
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6176: UMM: Implement getter for address environment heap start vaddr
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6176:
URL: https://github.com/apache/incubator-nuttx/pull/6176#discussion_r861898800
##########
binfmt/binfmt_execmodule.c:
##########
@@ -173,8 +174,15 @@ int exec_module(FAR const struct binary_s *binp,
goto errout_with_envp;
}
- binfo("Initialize the user heap (heapsize=%d)\n", binp->addrenv.heapsize);
- umm_initialize((FAR void *)CONFIG_ARCH_HEAP_VBASE, binp->addrenv.heapsize);
+ ret = up_addrenv_vheap(&binp->addrenv, &vheap);
+ if (ret < 0)
+ {
+ berr("ERROR: up_addrenv_vheap() failed: %d\n", ret);
+ goto errout_with_addrenv;
+ }
+
+ binfo("Initialize the user heap (heapsize=%zu)\n", binp->addrenv.heapsize);
Review Comment:
binp->addrenv.heapsize->up_addrenv_heapsize(&binp->addrenv). @pussuw could you create a new patch fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6176: UMM: Implement getter for address environment heap start vaddr
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6176:
URL: https://github.com/apache/incubator-nuttx/pull/6176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6176: UMM: Implement getter for address environment heap start vaddr
Posted by GitBox <gi...@apache.org>.
pussuw commented on code in PR #6176:
URL: https://github.com/apache/incubator-nuttx/pull/6176#discussion_r861925157
##########
binfmt/binfmt_execmodule.c:
##########
@@ -173,8 +174,15 @@ int exec_module(FAR const struct binary_s *binp,
goto errout_with_envp;
}
- binfo("Initialize the user heap (heapsize=%d)\n", binp->addrenv.heapsize);
- umm_initialize((FAR void *)CONFIG_ARCH_HEAP_VBASE, binp->addrenv.heapsize);
+ ret = up_addrenv_vheap(&binp->addrenv, &vheap);
+ if (ret < 0)
+ {
+ berr("ERROR: up_addrenv_vheap() failed: %d\n", ret);
+ goto errout_with_addrenv;
+ }
+
+ binfo("Initialize the user heap (heapsize=%zu)\n", binp->addrenv.heapsize);
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org