You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/06/07 17:10:54 UTC

[PR] [fix][misc] Add proper nslookup (included in bind-utils) to docker image [pulsar]

lhotari opened a new pull request, #22878:
URL: https://github.com/apache/pulsar/pull/22878

   Fixes: #22877 
   
   ### Motivation
   
   The default `nslookup` in Alpine is based on busybox and it isn't compatible with Kubernetes. See #22877 for more details.
   
   ### Modifications
   
   Install `bind-utils` package to get proper `nslookup`
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][misc] Add proper nslookup (included in bind-tools) to docker image [pulsar]

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on PR #22878:
URL: https://github.com/apache/pulsar/pull/22878#issuecomment-2155261885

   > > I assume `bind-utils` is light-weight.
   > 
   > It is. The downside is that it could contain vulnerabilities which show up in scanning. However there doesn't seem to be an alternative for backwards compatibility with Pulsar helm charts that use nslookup to check when another component is available.
   
   After we do the `RUN apk upgrade --no-cache` step, it's picking up the latest version, with no vulnerabilities


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][misc] Add proper nslookup (included in bind-tools) to docker image [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed pull request #22878: [fix][misc] Add proper nslookup (included in bind-tools) to docker image
URL: https://github.com/apache/pulsar/pull/22878


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][misc] Add proper nslookup (included in bind-tools) to docker image [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #22878:
URL: https://github.com/apache/pulsar/pull/22878


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][misc] Add proper nslookup (included in bind-tools) to docker image [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22878:
URL: https://github.com/apache/pulsar/pull/22878#issuecomment-2155285331

   Pulsar cluster gets initialized properly with Apache Pulsar Helm chart when using nslookup from bind-tools package. Here's the way I tested: https://github.com/lhotari/pulsar-helm-chart/pull/10/files#diff-f34da55ca08f1a30591d8b0b3e885bcc678537b2a9a4aadea4f190806b374ddcR3 . Pushed the image to https://hub.docker.com/r/lhotari/pulsar-all/tags (`docker pull lhotari/pulsar-all:3.3.0-nslookup`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][misc] Add proper nslookup (included in bind-tools) to docker image [pulsar]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #22878:
URL: https://github.com/apache/pulsar/pull/22878#issuecomment-2155469549

   ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22878?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 73.29%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9147edf`)](https://app.codecov.io/gh/apache/pulsar/commit/9147edf38c71dd2a8b4dfb622ae2d247981ec775?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 363 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/22878/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/22878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #22878      +/-   ##
   ============================================
   - Coverage     73.57%   73.29%   -0.28%     
   - Complexity    32624    32702      +78     
   ============================================
     Files          1877     1889      +12     
     Lines        139502   141885    +2383     
     Branches      15299    15565     +266     
   ============================================
   + Hits         102638   103997    +1359     
   - Misses        28908    29877     +969     
   - Partials       7956     8011      +55     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22878/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22878/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.20% <ø> (+2.62%)` | :arrow_up: |
   | [systests](https://app.codecov.io/gh/apache/pulsar/pull/22878/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.70% <ø> (+0.37%)` | :arrow_up: |
   | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22878/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.33% <ø> (-0.51%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 392 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22878/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][misc] Add proper nslookup (included in bind-utils) to docker image [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22878:
URL: https://github.com/apache/pulsar/pull/22878#issuecomment-2155249661

   > I assume `bind-utils` is light-weight.
   
   It is. The downside is that it could contain vulnerabilities which show up in scanning. However there doesn't seem to be an alternative for backwards compatibility with Pulsar helm charts that use nslookup to check when another component is available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][misc] Add proper nslookup (included in bind-tools) to docker image [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22878:
URL: https://github.com/apache/pulsar/pull/22878#issuecomment-2155259343

   The correct package name in Alpine is `bind-tools`. Testing it soon with Apache Pulsar Helm chart.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org