You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/23 12:13:33 UTC

[GitHub] wrp commented on a change in pull request #3785: [AIRFLOW-2938] Handle improperly formatted extra field in connection …

wrp commented on a change in pull request #3785: [AIRFLOW-2938] Handle improperly formatted extra field in connection …
URL: https://github.com/apache/incubator-airflow/pull/3785#discussion_r212284424
 
 

 ##########
 File path: airflow/www_rbac/views.py
 ##########
 @@ -1923,7 +1923,10 @@ def prefill_form(self, form, pk):
             d = {}
 
         for field in self.extra_fields:
-            value = d.get(field, '')
+            try:
+                value = d.get(field, '')
+            except Exception:
 
 Review comment:
   Yes.  I'm not sure if we should log something here, but once in that state it becomes difficult to edit the extra field from the UI

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services