You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/01 17:20:35 UTC

[GitHub] [flink-kubernetes-operator] morhidi commented on a change in pull request #27: [FLINK-26328] Control Logging Behavior in Flink Deployments

morhidi commented on a change in pull request #27:
URL: https://github.com/apache/flink-kubernetes-operator/pull/27#discussion_r816983564



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkConfigBuilder.java
##########
@@ -80,6 +83,17 @@ public FlinkConfigBuilder applyFlinkConfiguration() {
         return this;
     }
 
+    public FlinkConfigBuilder applyLogConfiguration() throws IOException {
+        if (spec.getLogConfiguration() != null) {
+            String confDir =
+                    createLogConfigFiles(
+                            spec.getLogConfiguration().get(CONFIG_FILE_LOG4J_NAME),

Review comment:
       Thanks, @gyfora. Makes sense!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org