You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "brancz (via GitHub)" <gi...@apache.org> on 2023/08/28 08:31:39 UTC

[GitHub] [arrow] brancz opened a new issue, #37416: [Go] Allow access to dict builder indices

brancz opened a new issue, #37416:
URL: https://github.com/apache/arrow/issues/37416

   ### Describe the enhancement requested
   
   I have a case where I have a mix of an external dictionary that I have indexes into and new values that I would like to append in a `BinaryDictionaryBuilder`. Starting with `InsertDictValues` while having some cost, seems negligible at the moment (although starting out with a dictionary and not caring about potential duplication would be a nice option to have), `AppendIndices` appears to be very expensive because of the slices it allocates (in our case about 10% of all CPU time in our query).
   
   To combat this, it would be great to allow access to the underlying indices builder to perform optimizations like this, then it would be the caller's responsibility to make sure the dict item exists, but the cost of the slice allocation can be alleviated as well.
   
   @zeroshade 
   
   ### Component(s)
   
   Go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] brancz commented on issue #37416: [Go] Allow access to dict builder indices

Posted by "brancz (via GitHub)" <gi...@apache.org>.

brancz commented on issue #37416:
URL: https://github.com/apache/arrow/issues/37416#issuecomment-1695291578

   Already opened the PR since it was a tiny change: https://github.com/apache/arrow/pull/37417


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade closed issue #37416: [Go] Allow access to dict builder indices

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.

zeroshade closed issue #37416: [Go] Allow access to dict builder indices
URL: https://github.com/apache/arrow/issues/37416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org