[incubator-echarts] 02/08: enhance: adjust insideFill/insideStroke

[su...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sushuang pushed a commit to branch attached-text
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 5cb15bc7e679ce968837a891a98fc8fc124cad17
Author: 100pah <su...@gmail.com>
AuthorDate: Mon Apr 20 22:36:55 2020 +0800

    enhance: adjust insideFill/insideStroke
---
 src/util/graphic.ts | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/src/util/graphic.ts b/src/util/graphic.ts
index 727fd40..88eecf8 100644
--- a/src/util/graphic.ts
+++ b/src/util/graphic.ts
@@ -799,17 +799,19 @@ export function createTextConfig(
     }
 
     // fill and auto is determined by the color of path fill if it's not specified by developers.
-    if (!textStyle.fill) {
-        textConfig.insideFill = 'auto';
-        textConfig.outsideFill = opt.autoColor || null;
-    }
-    if (!textStyle.stroke) {
-        textConfig.insideStroke = 'auto';
-    }
-    else if (opt.autoColor) {
-        // TODO: stroke set to autoColor. if label is inside?
-        textConfig.insideStroke = opt.autoColor;
-    }
+    textConfig.outsideFill = opt.autoColor || null;
+    textConfig.insideStroke = opt.autoColor || null;
+    // if (!textStyle.fill) {
+    //     textConfig.insideFill = 'auto';
+    //     textConfig.outsideFill = opt.autoColor || null;
+    // }
+    // if (!textStyle.stroke) {
+    //     textConfig.insideStroke = 'auto';
+    // }
+    // else if (opt.autoColor) {
+    //     // TODO: stroke set to autoColor. if label is inside?
+    //     textConfig.insideStroke = opt.autoColor;
+    // }
 
     return textConfig;
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org