[GitHub] [geode] upthewaterspout commented on a change in pull request #6560: GEODE-9168: Remove radish function execution

[GitBox <gi...@apache.org>]

upthewaterspout commented on a change in pull request #6560:
URL: https://github.com/apache/geode/pull/6560#discussion_r647620570



##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/RegionProvider.java
##########
@@ -45,15 +73,33 @@
 
   public static final int REDIS_SLOTS_PER_BUCKET = REDIS_SLOTS / REDIS_REGION_BUCKETS;
 
+  private static final Map<RedisDataType, RedisData> nullTypes = new HashMap<>();

Review comment:
       Could be an EnumMap. Also, maybe it should be `NULL_TYPES` since it's static?

##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisKey.java
##########
@@ -63,7 +63,7 @@ public RedisKey(byte[] value) {
 
   public int getBucketId() {
     // & (REDIS_SLOTS - 1) is equivalent to % REDIS_SLOTS but supposedly faster
-    return getCrc16() & (REDIS_SLOTS - 1) / REDIS_SLOTS_PER_BUCKET;
+    return (getCrc16() & (REDIS_SLOTS - 1)) / REDIS_SLOTS_PER_BUCKET;

Review comment:
       Whoa!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org