You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pm...@apache.org on 2014/11/15 19:27:40 UTC
weinre commit: fix for CB-8023 - weinre console.log fails when given null value

Repository: cordova-weinre
Updated Branches:
  refs/heads/master 707a7a1bf -> 04ba61d96


fix for CB-8023 - weinre console.log fails when given null value


Project: http://git-wip-us.apache.org/repos/asf/cordova-weinre/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-weinre/commit/04ba61d9
Tree: http://git-wip-us.apache.org/repos/asf/cordova-weinre/tree/04ba61d9
Diff: http://git-wip-us.apache.org/repos/asf/cordova-weinre/diff/04ba61d9

Branch: refs/heads/master
Commit: 04ba61d963c7f1774b4bff5d7eb3a5772e3f7088
Parents: 707a7a1
Author: Patrick Mueller <pm...@apache.org>
Authored: Sat Nov 15 12:27:17 2014 -0600
Committer: Patrick Mueller <pm...@apache.org>
Committed: Sat Nov 15 12:27:17 2014 -0600

----------------------------------------------------------------------
 weinre.web/demo/weinre-demo.js                  | 6 +++++-
 weinre.web/modules/weinre/target/Console.coffee | 2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-weinre/blob/04ba61d9/weinre.web/demo/weinre-demo.js
----------------------------------------------------------------------
diff --git a/weinre.web/demo/weinre-demo.js b/weinre.web/demo/weinre-demo.js
index 124e298..c5b1238 100644
--- a/weinre.web/demo/weinre-demo.js
+++ b/weinre.web/demo/weinre-demo.js
@@ -68,16 +68,21 @@ function onLoad() {
 var interval
 
 function startStuff() {
+    console.log() // test for https://issues.apache.org/jira/browse/CB-8023
+
     if (window.localStorage)   window.localStorage.clear()
     if (window.sessionStorage) window.sessionStorage.clear()
 
     storageIndex = 0
 
     interval = setInterval(intervalStuff, 1000)
+
+    console.log("stuff starting")
 }
 
 function stopStuff() {
     clearInterval(interval)
+    console.log("stuff stopping")
 }
 
 //------------------------------------------------------------------------------
@@ -182,4 +187,3 @@ function output(string) {
 function logXhr(xhr) {
     console.log("xhr: readyState: " + xhr.readyState)
 }
-

http://git-wip-us.apache.org/repos/asf/cordova-weinre/blob/04ba61d9/weinre.web/modules/weinre/target/Console.coffee
----------------------------------------------------------------------
diff --git a/weinre.web/modules/weinre/target/Console.coffee b/weinre.web/modules/weinre/target/Console.coffee
index cf6624a..aec70be 100644
--- a/weinre.web/modules/weinre/target/Console.coffee
+++ b/weinre.web/modules/weinre/target/Console.coffee
@@ -75,6 +75,8 @@ module.exports = class Console
 
     #---------------------------------------------------------------------------
     _generic: (level, messageParts) ->
+        return if !messageParts?.length
+
         message = messageParts[0].toString()
         parameters = []
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org