You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by an...@apache.org on 2015/09/03 09:15:45 UTC

cordova-lib git commit: CB-9587 Check if browser platform added properly before creating parser. This closes #293

Repository: cordova-lib
Updated Branches:
  refs/heads/master 3951a990c -> 4ca15f2be


CB-9587 Check if browser platform added properly before creating parser. This closes #293


Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/4ca15f2b
Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/4ca15f2b
Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/4ca15f2b

Branch: refs/heads/master
Commit: 4ca15f2be2fbe1ee43949fcd86825bf1d4dd1ecc
Parents: 3951a99
Author: Vladimir Kotikov <v-...@microsoft.com>
Authored: Tue Sep 1 14:45:17 2015 +0300
Committer: Vladimir Kotikov <v-...@microsoft.com>
Committed: Thu Sep 3 10:16:04 2015 +0300

----------------------------------------------------------------------
 cordova-lib/src/cordova/metadata/browser_parser.js | 8 ++++++++
 1 file changed, 8 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/4ca15f2b/cordova-lib/src/cordova/metadata/browser_parser.js
----------------------------------------------------------------------
diff --git a/cordova-lib/src/cordova/metadata/browser_parser.js b/cordova-lib/src/cordova/metadata/browser_parser.js
index 66adef5..9cf694b 100644
--- a/cordova-lib/src/cordova/metadata/browser_parser.js
+++ b/cordova-lib/src/cordova/metadata/browser_parser.js
@@ -23,10 +23,18 @@ var fs = require('fs'),
     path = require('path'),
     shell = require('shelljs'),
     util = require('../util'),
+    CordovaError = require('../../CordovaError'),
     Q = require('q'),
     Parser = require('./parser');
 
+function dirExists(dir) {
+    return fs.existsSync(dir) && fs.statSync(dir).isDirectory();
+}
+
 function browser_parser(project) {
+    if (!dirExists(project) || !dirExists(path.join(project, 'cordova'))) {
+        throw new CordovaError('The provided path "' + project + '" is not a valid browser project.');
+    }
 
     // Call the base class constructor
     Parser.call(this, 'browser', project);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org