You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2025/11/19 18:03:42 UTC
[PR] fix(go/adbc/sqldriver): properly close resources [arrow-adbc]
zeroshade opened a new pull request, #3731:
URL: https://github.com/apache/arrow-adbc/pull/3731
fixes #3728
This was a combination of two issues that are fixed in this PR:
1. `sqldriver.Connector` needs to implement the `io.Closer` interface so that `sql.DB.Close` will call it and call `Close` on the `adbc.Database` object.
2. `rows.Close` needs to also close the associated `stmt`. In the case of at least one driver (the duckdb driver in associated issue) not closing the `stmt` led to the handle to the duckdb database not being dropped despite calling `Close` on the database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(go/adbc/sqldriver): properly close resources [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #3731:
URL: https://github.com/apache/arrow-adbc/pull/3731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org