You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/02/01 04:28:29 UTC
[kudu-CR] KUDU-2279 (part 5): don't include entity attributes in log
Hello Will Berkeley, Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9180
to review the following change.
Change subject: KUDU-2279 (part 5): don't include entity attributes in log
......................................................................
KUDU-2279 (part 5): don't include entity attributes in log
Entity attributes like table names and partition descriptions aren't
very useful in the context of the metrics log. They can always be
grabbed from other places like 'kudu remote_replica list', etc, and are
rarely relevant for tserver-scope debugging.
Additionally, these might be considered somewhat sensitive for users to
share publically in bug reports, etc, so may as well "redact" them.
This shaves a few more bytes off the entries in the metrics log.
Change-Id: Ic995f6a3b8430b73a041de8e5bcbc53a5d8e7f1b
---
M src/kudu/server/server_base.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
3 files changed, 15 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/9180/1
--
To view, visit http://gerrit.cloudera.org:8080/9180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic995f6a3b8430b73a041de8e5bcbc53a5d8e7f1b
Gerrit-Change-Number: 9180
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2279 (part 5): don't include entity attributes in log
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9180 )
Change subject: KUDU-2279 (part 5): don't include entity attributes in log
......................................................................
Patch Set 3: Code-Review+2
Carrying +2
--
To view, visit http://gerrit.cloudera.org:8080/9180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic995f6a3b8430b73a041de8e5bcbc53a5d8e7f1b
Gerrit-Change-Number: 9180
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Feb 2018 07:59:12 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2279 (part 5): don't include entity attributes in log
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9180
to look at the new patch set (#3).
Change subject: KUDU-2279 (part 5): don't include entity attributes in log
......................................................................
KUDU-2279 (part 5): don't include entity attributes in log
Entity attributes like table names and partition descriptions aren't
very useful in the context of the metrics log. They can always be
grabbed from other places like 'kudu remote_replica list', etc, and are
rarely relevant for tserver-scope debugging.
Additionally, these might be considered somewhat sensitive for users to
share publically in bug reports, etc, so may as well "redact" them.
This shaves a few more bytes off the entries in the metrics log.
Change-Id: Ic995f6a3b8430b73a041de8e5bcbc53a5d8e7f1b
---
M src/kudu/server/server_base.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
3 files changed, 15 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/9180/3
--
To view, visit http://gerrit.cloudera.org:8080/9180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic995f6a3b8430b73a041de8e5bcbc53a5d8e7f1b
Gerrit-Change-Number: 9180
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2279 (part 5): don't include entity attributes in log
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9180 )
Change subject: KUDU-2279 (part 5): don't include entity attributes in log
......................................................................
KUDU-2279 (part 5): don't include entity attributes in log
Entity attributes like table names and partition descriptions aren't
very useful in the context of the metrics log. They can always be
grabbed from other places like 'kudu remote_replica list', etc, and are
rarely relevant for tserver-scope debugging.
Additionally, these might be considered somewhat sensitive for users to
share publically in bug reports, etc, so may as well "redact" them.
This shaves a few more bytes off the entries in the metrics log.
Change-Id: Ic995f6a3b8430b73a041de8e5bcbc53a5d8e7f1b
Reviewed-on: http://gerrit.cloudera.org:8080/9180
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/server/server_base.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
3 files changed, 15 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic995f6a3b8430b73a041de8e5bcbc53a5d8e7f1b
Gerrit-Change-Number: 9180
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2279 (part 5): don't include entity attributes in log
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9180 )
Change subject: KUDU-2279 (part 5): don't include entity attributes in log
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic995f6a3b8430b73a041de8e5bcbc53a5d8e7f1b
Gerrit-Change-Number: 9180
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 02 Feb 2018 20:47:10 +0000
Gerrit-HasComments: No