You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/10 14:31:52 UTC

[GitHub] [trafficserver] ema commented on pull request #6908: Handle Transfer-Encoding as a hop-by-hop header

ema commented on pull request #6908:
URL: https://github.com/apache/trafficserver/pull/6908#issuecomment-656707041


   Thanks so much for looking into this @shinrich!
   
   > ATS is stripping the Transfer-Encoding header so the test origin has no indication of the length of the request body.
   
   On TE:chunked responses, however, with this patch applied ATS is doing the right thing and adding TE:chunked when sending a chunked response for cache misses. On cache hit it properly returns a non-chunked response with Content-Length instead. We have been using the patch in production for a while now, and haven't had troubles: https://github.com/wikimedia/operations-debs-trafficserver/blob/master/debian/patches/0062-TE-hop-by-hop.patch
   
   It seems to me that the proper solution would be ensuring that, if a chunked **request** is sent, ATS adds TE:chunked to the request headers.
   
   I agree with @maskit when he says that it would be strange if we couldn't define Transfer-Encoding as hop-by-hop, given that it is clearly described as such by the RFC.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org