[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

[squito <gi...@git.apache.org>]

Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21221#discussion_r206995945
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/ExecutorMetrics.scala ---
    @@ -0,0 +1,81 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.executor
    +
    +import org.apache.spark.annotation.DeveloperApi
    +import org.apache.spark.metrics.ExecutorMetricType
    +
    +/**
    + * :: DeveloperApi ::
    + * Metrics tracked for executors and the driver.
    + *
    + * Executor-level metrics are sent from each executor to the driver as part of the Heartbeat.
    + */
    +@DeveloperApi
    +class ExecutorMetrics private[spark] extends Serializable {
    +
    +  // Metrics are indexed by MetricGetter.values
    +  private val metrics = new Array[Long](ExecutorMetricType.values.length)
    --- End diff --
    
    I suggested this earlier in the reviews.  Most of the operations for dealing with this data want to iterate over all the fields.  its much easier this way vs. having a bazillion
    
    ```scala
    if (x.fizz > y.fizz) { 
      y.fizz = x.fizz
    }
    if (x.buzz > y.buzz) {
      y.buzz = x.buzz
    }
    ...
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org