You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "darkSheep404 (via GitHub)" <gi...@apache.org> on 2023/07/31 13:42:25 UTC
[GitHub] [apisix] darkSheep404 opened a new pull request, #9938: docs: add proxy_opts attribute for openid-connect.md (#9922)
darkSheep404 opened a new pull request, #9938:
URL: https://github.com/apache/apisix/pull/9938
### Description
update openid-connect docs, add attribute proxy-opts,which enable openid-connect access oauth2 server with http-proxy sever
更新openid-connect 文档 添加属性 proxy-opts,通过配置此属性 可以使得openid-connect 使用代理服务器访问 配置的oauth2服务器
Fixes # (issue)
https://github.com/apache/apisix/issues/9922
hi @Sn0rt
Can you please help me to review this PR
After our last discussion, by reading the `openid-connect.lua` and `openidc.lua` source code I found the available configuration items and tested them in my online environment
If there is no problem, I will update it to the document the LTS version too.
But there seems to be no better way for me to update all the documentation at once than to give each release a PR
你可以帮我review这个PR吗
在我们上次讨论之后 通过阅读openid-connet与openid的源码 我找到了可用的配置项,并且在我的线上环测试过是可行的
如果没问题的话 我会再把它更新到LTS版本的文档
不过似乎我没有更好的方式去一次性更新所有文档 除了给每个版本都提一次PR
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] darkSheep404 closed pull request #9938: docs: add proxy_opts attribute for openid-connect.md (#9922)
Posted by "darkSheep404 (via GitHub)" <gi...@apache.org>.
darkSheep404 closed pull request #9938: docs: add proxy_opts attribute for openid-connect.md (#9922)
URL: https://github.com/apache/apisix/pull/9938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] darkSheep404 commented on pull request #9938: docs: add proxy_opts attribute for openid-connect.md (#9922)
Posted by "darkSheep404 (via GitHub)" <gi...@apache.org>.
darkSheep404 commented on PR #9938:
URL: https://github.com/apache/apisix/pull/9938#issuecomment-1658509399
by the way,this pr only add a proxy_opts attribute to doc,if use git tools which can ignore format and emptylines will be more clearly,The indentation above is affected because markdown's table has been modified by adding a new line
捎带说一下 这个PR 其实只加了一个属性到文档,如果使用忽略格式化和空行的git 工具可以更清晰的看到更改. 因为修改了markdown的table,加了一行 所以影响到了上面的缩进
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org