You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/01/20 17:06:39 UTC
[jira] [Commented] (FLINK-2933) Flink scala libraries exposed with
maven should carry scala version
[ https://issues.apache.org/jira/browse/FLINK-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108794#comment-15108794 ]
ASF GitHub Bot commented on FLINK-2933:
---------------------------------------
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1529
[FLINK-2933] Flink scala libraries exposed with maven should carry scala version
This pull request adds Scala suffixes to all Maven modules which dependent on a Scala version. The default Scala version is 2.10. It also includes a small script to list Scala-dependent modules. The current situation looks like this:
```
The following modules DON'T have a dependency on Scala:
flink-parent
flink-annotations
flink-batch-connectors
flink-contrib-parent
flink-core
flink-hcatalog
flink-jdbc
flink-libraries
flink-quickstart
flink-quickstart-java
flink-quickstart-scala
flink-shaded-curator
flink-shaded-curator-recipes
flink-shaded-curator-test
flink-shaded-hadoop
flink-shaded-hadoop2
flink-shaded-include-yarn-tests
flink-streaming-connectors
The following modules have a dependency on Scala:
flink-avro
flink-clients
flink-connector-elasticsearch
flink-connector-filesystem
flink-connector-flume
flink-connector-kafka
flink-connector-nifi
flink-connector-rabbitmq
flink-connector-twitter
flink-connector-wikiedits
flink-dist
flink-examples
flink-examples-batch
flink-examples-streaming
flink-fs-tests
flink-gelly
flink-gelly-scala
flink-hadoop-compatibility
flink-hbase
flink-java
flink-java8
flink-ml
flink-operator-stats
flink-optimizer
flink-python
flink-runtime
flink-runtime-web
flink-scala
flink-scala-shell
flink-storm
flink-storm-examples
flink-streaming-contrib
flink-streaming-java
flink-streaming-scala
flink-table
flink-test-utils
flink-tests
flink-tweet-inputformat
flink-yarn
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-2940
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1529.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1529
----
commit bac800a3c23f675e983fb744bbe747e30c5ca7b0
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-01-20T09:39:40Z
add Scala suffixes to Scala dependent modules
commit 6a958abfaf221f75706ec630cd6bea3097f03bfc
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-01-20T14:22:55Z
remove scala suffix from scala-free modules
commit 452d76d2c4dd8028add9957941601849d8433082
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-01-20T15:43:19Z
[tools] adapt change-scala-version script
commit 0eb69085ba1c95ff150d47b435f0072642345c8c
Author: Maximilian Michels <mx...@apache.org>
Date: 2016-01-20T15:50:18Z
[tools] add script to list Scala dependent modules
----
> Flink scala libraries exposed with maven should carry scala version
> -------------------------------------------------------------------
>
> Key: FLINK-2933
> URL: https://issues.apache.org/jira/browse/FLINK-2933
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Reporter: Frederick F. Kautz IV
> Assignee: Maximilian Michels
> Priority: Minor
>
> [If I put this on the wrong component, can someone please update?]
> Major versions of scala are not forward nor backwards compatible. Libraries build for 2.10 will not work with 2.11 or vice versa.
> In order to avoid build related problems, it is strongly recommended to append the scala version it is compatible within the artifact id. This ensures the correct version of the library is pulled in rather than deferring the problem to a future build or runtime error.
> For example, akka exposes the following packages for the same version:
> {code}
> <dependency>
> <groupId>com.typesafe.akka</groupId>
> <artifactId>akka-actor_2.10</artifactId>
> <version>2.3.14</version>
> </dependency>
> {code}
> {code}
> <dependency>
> <groupId>com.typesafe.akka</groupId>
> <artifactId>akka-actor_2.11</artifactId>
> <version>2.3.14</version>
> </dependency>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)