You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/02 03:19:55 UTC
[GitHub] [shardingsphere] jiangML opened a new pull request, #21901: Optimize distsql about readwrite splitting
jiangML opened a new pull request, #21901:
URL: https://github.com/apache/shardingsphere/pull/21901
For #21694
Changes proposed in this pull request:
- Optimize distsql about readwrite splitting
- Add test
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #21901: Optimize distsql about readwrite splitting
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #21901:
URL: https://github.com/apache/shardingsphere/pull/21901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21901: Optimize distsql about readwrite splitting
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21901:
URL: https://github.com/apache/shardingsphere/pull/21901#issuecomment-1299571094
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21901?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21901](https://codecov.io/gh/apache/shardingsphere/pull/21901?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f649ca) into [master](https://codecov.io/gh/apache/shardingsphere/commit/377e1c12821b112589a7ed762f5ba5ad4e918748?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (377e1c1) will **increase** coverage by `0.01%`.
> The diff coverage is `32.75%`.
```diff
@@ Coverage Diff @@
## master #21901 +/- ##
============================================
+ Coverage 61.07% 61.08% +0.01%
- Complexity 2454 2458 +4
============================================
Files 4102 4104 +2
Lines 57162 57173 +11
Branches 9661 9659 -2
============================================
+ Hits 34909 34926 +17
+ Misses 19334 19326 -8
- Partials 2919 2921 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21901?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ore/ReadwriteSplittingDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/21901/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9kaXN0c3FsL3BhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvUmVhZHdyaXRlU3BsaXR0aW5nRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `41.02% <0.00%> (ø)` | |
| [...howStatusFromReadwriteSplittingRulesStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/21901/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9kaXN0c3FsL3N0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9TaG93U3RhdHVzRnJvbVJlYWR3cml0ZVNwbGl0dGluZ1J1bGVzU3RhdGVtZW50LmphdmE=) | `0.00% <ø> (ø)` | |
| [...rReadwriteSplittingStorageUnitStatusStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/21901/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9kaXN0c3FsL3N0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmVhZHdyaXRlc3BsaXR0aW5nL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9zdGF0dXMvQWx0ZXJSZWFkd3JpdGVTcGxpdHRpbmdTdG9yYWdlVW5pdFN0YXR1c1N0YXRlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [.../ShowStatusFromReadwriteSplittingRulesHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21901/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3F1ZXJ5YWJsZS9TaG93U3RhdHVzRnJvbVJlYWR3cml0ZVNwbGl0dGluZ1J1bGVzSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...iteSplittingStorageUnitStatusStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21901/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9BbHRlclJlYWR3cml0ZVNwbGl0dGluZ1N0b3JhZ2VVbml0U3RhdHVzU3RhdGVtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...tusFromReadwriteSplittingRulesStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21901/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvcXVlcnlhYmxlL1Nob3dTdGF0dXNGcm9tUmVhZHdyaXRlU3BsaXR0aW5nUnVsZXNTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `40.00% <0.00%> (ø)` | |
| [...riteSplittingStorageUnitStatusStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21901/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvdXBkYXRhYmxlL0FsdGVyUmVhZHdyaXRlU3BsaXR0aW5nU3RvcmFnZVVuaXRTdGF0dXNTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `69.23% <69.23%> (ø)` | |
| [.../handler/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/21901/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `75.60% <100.00%> (ø)` | |
| [.../distsql/ral/impl/QueryableRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21901/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvUXVlcnlhYmxlUkFMU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `96.55% <100.00%> (ø)` | |
| [.../distsql/ral/impl/UpdatableRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/21901/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2Fzc2VydHMvc3RhdGVtZW50L2Rpc3RzcWwvcmFsL2ltcGwvVXBkYXRhYmxlUkFMU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/shardingsphere/pull/21901/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org