You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by vl...@apache.org on 2025/10/31 17:48:22 UTC

(jmeter) 03/03: test: JUnit5 does not execute static test methods, so revert static modifiers

This is an automated email from the ASF dual-hosted git repository.

vladimirsitnikov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git

commit 2c17f5d2b6b0fa7e0f69dbd56785386a785c8745
Author: Vladimir Sitnikov <si...@gmail.com>
AuthorDate: Fri Oct 31 20:47:15 2025 +0300

    test: JUnit5 does not execute static test methods, so revert static modifiers
---
 .../jmeter/visualizers/backend/SamplerMetricFixedModeTest.java      | 6 +++---
 .../jmeter/visualizers/backend/SamplerMetricTimedModeTest.java      | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/components/src/test/java/org/apache/jmeter/visualizers/backend/SamplerMetricFixedModeTest.java b/src/components/src/test/java/org/apache/jmeter/visualizers/backend/SamplerMetricFixedModeTest.java
index f174d2582b..63dfa566d0 100644
--- a/src/components/src/test/java/org/apache/jmeter/visualizers/backend/SamplerMetricFixedModeTest.java
+++ b/src/components/src/test/java/org/apache/jmeter/visualizers/backend/SamplerMetricFixedModeTest.java
@@ -78,7 +78,7 @@ public class SamplerMetricFixedModeTest {
     }
 
     @Test
-    public static void checkErrorsDetailStat() {
+    public void checkErrorsDetailStat() {
         SamplerMetric metric = new SamplerMetric();
         metric.add(createSampleResult("400", "bad request"));
         metric.add(createSampleResult("400", "Bad Request "));
@@ -124,7 +124,7 @@ public class SamplerMetricFixedModeTest {
     }
 
     @Test
-    public static void checkAddCumulatedOk() throws Exception {
+    public void checkAddCumulatedOk() throws Exception {
         SamplerMetric metric = new SamplerMetric();
         SampleResult sample = createSampleResultWithSubresults(true);
         assertEquals(true, TransactionController.isFromTransactionController(sample), "We are recognized as a TransactionController made sample");
@@ -145,7 +145,7 @@ public class SamplerMetricFixedModeTest {
     }
 
     @Test
-    public static void checkAddCumulatedKo() throws Exception {
+    public void checkAddCumulatedKo() throws Exception {
         SamplerMetric metric = new SamplerMetric();
         SampleResult sample = createSampleResultWithSubresults(false);
         assertEquals(true, TransactionController.isFromTransactionController(sample), "We are recognized as a TransactionController made sample");
diff --git a/src/components/src/test/java/org/apache/jmeter/visualizers/backend/SamplerMetricTimedModeTest.java b/src/components/src/test/java/org/apache/jmeter/visualizers/backend/SamplerMetricTimedModeTest.java
index 3cb898f1f7..420bd6a970 100644
--- a/src/components/src/test/java/org/apache/jmeter/visualizers/backend/SamplerMetricTimedModeTest.java
+++ b/src/components/src/test/java/org/apache/jmeter/visualizers/backend/SamplerMetricTimedModeTest.java
@@ -106,7 +106,7 @@ public class SamplerMetricTimedModeTest {
     }
 
     @Test
-    public static void checkAddCumulatedOk() throws Exception {
+    public void checkAddCumulatedOk() throws Exception {
         SamplerMetric metric = new SamplerMetric();
         SampleResult sample = createSampleResultWithSubresults(true);
         assertEquals(true, TransactionController.isFromTransactionController(sample), "We are recognized as a TransactionController made sample");
@@ -127,7 +127,7 @@ public class SamplerMetricTimedModeTest {
     }
 
     @Test
-    public static void checkAddCumulatedKo() throws Exception {
+    public void checkAddCumulatedKo() throws Exception {
         SamplerMetric metric = new SamplerMetric();
         SampleResult sample = createSampleResultWithSubresults(false);
         assertEquals(true, TransactionController.isFromTransactionController(sample), "We are recognized as a TransactionController made sample");