You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2019/11/19 12:36:54 UTC
[Bug 63938] New: CORS filter adds headers to non-CORS request
https://bz.apache.org/bugzilla/show_bug.cgi?id=63938
Bug ID: 63938
Summary: CORS filter adds headers to non-CORS request
Product: Tomcat 9
Version: 9.0.x
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: michaelo@apache.org
Target Milestone: -----
When the CorsFilter identifies a request as NOT_CORS, #handleNonCORS() still
calls #addStandardHeaders() and invokes filterChain.
While is not particularly wrong, the identified request is has no "Origin"
header and still serving those standard reponse headers is a waste of bytes w/o
any value to the client. One caveat I see is that a local origin request is
identified as NOT_CORS for some reason altough an "Origin" header has been
provided.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 63938] CORS filter adds headers to non-CORS request
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63938
--- Comment #3 from Michael Osipov <mi...@apache.org> ---
(In reply to Michael Osipov from comment #2)
> (In reply to Mark Thomas from comment #1)
> > This behaviour is deliberate. The reasoning is in the code comments. Also,
> > see bug 57724.
>
> I do not really understand the argumentation why a real on CORS-request
> should have these headers returned. Can you please point to the exact
> comment you refer to? I'd at least expect this to be configurable.
I really would like to settle this with the previous comment. I, frankly, would
like to understand this and request reconsider for a boolean parameter.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 63938] CORS filter adds headers to non-CORS request
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63938
Michael Osipov <mi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |michaelo@apache.org
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 63938] CORS filter adds headers to non-CORS request
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63938
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WONTFIX
Status|NEW |RESOLVED
--- Comment #1 from Mark Thomas <ma...@apache.org> ---
This behaviour is deliberate. The reasoning is in the code comments. Also, see
bug 57724.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 63938] CORS filter adds headers to non-CORS request
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63938
--- Comment #2 from Michael Osipov <mi...@apache.org> ---
(In reply to Mark Thomas from comment #1)
> This behaviour is deliberate. The reasoning is in the code comments. Also,
> see bug 57724.
I do not really understand the argumentation why a real on CORS-request should
have these headers returned. Can you please point to the exact comment you
refer to? I'd at least expect this to be configurable.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org