You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2019/03/18 21:32:59 UTC
Review Request 70233: Allowed for optionally unbundled ZooKeeper for
CMake builds.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Joseph Wu.
Bugs: MESOS-9662
https://issues.apache.org/jira/browse/MESOS-9662
Repository: mesos
Description
-------
Allowed for optionally unbundled ZooKeeper for CMake builds.
Diffs
-----
3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9
3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION
cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7
Diff: https://reviews.apache.org/r/70233/diff/1/
Testing
-------
Thanks,
Till Toenshoff
Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper
for CMake builds.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213786
-----------------------------------------------------------
PASS: Mesos patch 70233 was successfully built and tested.
Reviews applied: `['70233']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2977/mesos-review-70233
- Mesos Reviewbot Windows
On March 18, 2019, 2:32 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 2:32 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Bugs: MESOS-9662
> https://issues.apache.org/jira/browse/MESOS-9662
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allowed for optionally unbundled ZooKeeper for CMake builds.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9
> 3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION
> cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7
>
>
> Diff: https://reviews.apache.org/r/70233/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper
for CMake builds.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213787
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70233]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 18, 2019, 9:32 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 9:32 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Bugs: MESOS-9662
> https://issues.apache.org/jira/browse/MESOS-9662
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allowed for optionally unbundled ZooKeeper for CMake builds.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9
> 3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION
> cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7
>
>
> Diff: https://reviews.apache.org/r/70233/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper
for CMake builds.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213792
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70233]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 19, 2019, 8:11 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> -----------------------------------------------------------
>
> (Updated March 19, 2019, 8:11 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Bugs: MESOS-9662
> https://issues.apache.org/jira/browse/MESOS-9662
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allowed for optionally unbundled ZooKeeper for CMake builds.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9
> 3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION
> cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7
>
>
> Diff: https://reviews.apache.org/r/70233/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper
for CMake builds.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213790
-----------------------------------------------------------
PASS: Mesos patch 70233 was successfully built and tested.
Reviews applied: `['70233']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2979/mesos-review-70233
- Mesos Reviewbot Windows
On March 19, 2019, 12:11 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> -----------------------------------------------------------
>
> (Updated March 19, 2019, 12:11 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Bugs: MESOS-9662
> https://issues.apache.org/jira/browse/MESOS-9662
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allowed for optionally unbundled ZooKeeper for CMake builds.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9
> 3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION
> cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7
>
>
> Diff: https://reviews.apache.org/r/70233/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper
for CMake builds.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
> On March 19, 2019, 11:07 p.m., Joseph Wu wrote:
> > 3rdparty/cmake/FindZOOKEEPER.cmake
> > Lines 50 (patched)
> > <https://reviews.apache.org/r/70233/diff/1/?file=2132719#file2132719line50>
> >
> > I wonder if it is worth adding a note here, restating bits of the blurb here:
> > https://github.com/apache/zookeeper/blob/master/zookeeper-client/zookeeper-client-c/README#L26-L32
> >
> > We don't have a note in the autotools build.
Yeah, why not - its a good note...
> On March 19, 2019, 11:07 p.m., Joseph Wu wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 115 (patched)
> > <https://reviews.apache.org/r/70233/diff/1/?file=2132720#file2132720line115>
> >
> > Using a Windows style path here is... a bit funny to me. Nothing wrong with it though.
You are perfectly right, the last few times I followed this pattern, I smiled :D.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213810
-----------------------------------------------------------
On March 19, 2019, 12:11 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> -----------------------------------------------------------
>
> (Updated March 19, 2019, 12:11 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Bugs: MESOS-9662
> https://issues.apache.org/jira/browse/MESOS-9662
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allowed for optionally unbundled ZooKeeper for CMake builds.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9
> 3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION
> cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7
>
>
> Diff: https://reviews.apache.org/r/70233/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper
for CMake builds.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/#review213810
-----------------------------------------------------------
Ship it!
LGTM.
3rdparty/cmake/FindZOOKEEPER.cmake
Lines 50 (patched)
<https://reviews.apache.org/r/70233/#comment299871>
I wonder if it is worth adding a note here, restating bits of the blurb here:
https://github.com/apache/zookeeper/blob/master/zookeeper-client/zookeeper-client-c/README#L26-L32
We don't have a note in the autotools build.
cmake/CompilationConfigure.cmake
Lines 115 (patched)
<https://reviews.apache.org/r/70233/#comment299870>
Using a Windows style path here is... a bit funny to me. Nothing wrong with it though.
- Joseph Wu
On March 18, 2019, 5:11 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70233/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 5:11 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Bugs: MESOS-9662
> https://issues.apache.org/jira/browse/MESOS-9662
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allowed for optionally unbundled ZooKeeper for CMake builds.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9
> 3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION
> cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7
>
>
> Diff: https://reviews.apache.org/r/70233/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper
for CMake builds.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/
-----------------------------------------------------------
(Updated March 19, 2019, 12:11 a.m.)
Review request for mesos, Benjamin Bannier and Joseph Wu.
Bugs: MESOS-9662
https://issues.apache.org/jira/browse/MESOS-9662
Repository: mesos
Description
-------
Allowed for optionally unbundled ZooKeeper for CMake builds.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9
3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION
cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7
Diff: https://reviews.apache.org/r/70233/diff/3/
Changes: https://reviews.apache.org/r/70233/diff/2-3/
Testing
-------
Thanks,
Till Toenshoff
Re: Review Request 70233: Allowed for optionally unbundled ZooKeeper
for CMake builds.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70233/
-----------------------------------------------------------
(Updated March 19, 2019, 12:03 a.m.)
Review request for mesos, Benjamin Bannier and Joseph Wu.
Bugs: MESOS-9662
https://issues.apache.org/jira/browse/MESOS-9662
Repository: mesos
Description
-------
Allowed for optionally unbundled ZooKeeper for CMake builds.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9
3rdparty/cmake/FindZOOKEEPER.cmake PRE-CREATION
cmake/CompilationConfigure.cmake d9c1e40a59eebbb295aa993682edb8ccbf2b48f7
Diff: https://reviews.apache.org/r/70233/diff/2/
Changes: https://reviews.apache.org/r/70233/diff/1-2/
Testing
-------
Thanks,
Till Toenshoff