You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/02/26 23:03:45 UTC

[GitHub] [incubator-pinot] harleyjj opened a new pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…

harleyjj opened a new pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…
URL: https://github.com/apache/incubator-pinot/pull/5098
 
 
   …ain Cube Algorithm
   
   1) Adds tooltip for explaining the Cube Algorithm in Dimensions Tab of RCA page
   2) Cleans up a few eslint errors

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] cyenjung commented on a change in pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…

Posted by GitBox <gi...@apache.org>.
cyenjung commented on a change in pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…
URL: https://github.com/apache/incubator-pinot/pull/5098#discussion_r384839256
 
 

 ##########
 File path: thirdeye/thirdeye-frontend/app/pods/partials/rootcause/dimensions/template.hbs
 ##########
 @@ -3,6 +3,12 @@
     {{#subtablist.tab name="heatmap"}}Heatmap{{/subtablist.tab}}
     {{#subtablist.tab name="table"}}Table{{/subtablist.tab}}
     {{#subtablist.tab name="algorithm"}}Algorithm{{/subtablist.tab}}
+    <span>
+      <i class="glyphicon glyphicon-question-sign"></i>
+      {{#bs-popover placement="bottom" title="What do the options mean?"}}
+        {{cube-tooltip}}
+      {{/bs-popover}}
+    </span>
 
 Review comment:
   Is it possible to put this question sign next to
   1. "Color heatmap by" when the user selects the heatmap tab and
   2. At the end of the cell "Contribution to Overall Change" and "Change in Contribution?" when in the Algorithm tab.
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] cyenjung commented on a change in pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…

Posted by GitBox <gi...@apache.org>.
cyenjung commented on a change in pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…
URL: https://github.com/apache/incubator-pinot/pull/5098#discussion_r384837227
 
 

 ##########
 File path: thirdeye/thirdeye-frontend/app/pods/components/cube-tooltip/template.hbs
 ##########
 @@ -0,0 +1,21 @@
+<div class="te-tooltip__body te-tooltip__body--large">
+  <div>
+    <span class="te-tooltip__title te-tooltip__title--small">Definition of Terms</span>
+  </div>
+  <p>CV: current value<br/>
+    PV: previous (baseline) value<br/>
+    SUM_CV: total value<br/>
+    SUM_PV: total previous (baseline) value
+  </p>
+  <div>
+    <span class="te-tooltip__title te-tooltip__title--small">Formulas</span>
+  </div>
+  <p>Percentage Change: (CV -PV) * 100 / PV<br/>
+    Change in Contribution: (CV/SUM_CV -PV/ SUM_PV) * 100<br/>
+    Contribution to Overall Change: (CV -PV) * 100 / (SUM_CV-SUM_PV)
 
 Review comment:
   Same comment here :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…

Posted by GitBox <gi...@apache.org>.
akshayrai commented on a change in pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…
URL: https://github.com/apache/incubator-pinot/pull/5098#discussion_r384834962
 
 

 ##########
 File path: thirdeye/thirdeye-frontend/app/pods/components/cube-tooltip/template.hbs
 ##########
 @@ -0,0 +1,21 @@
+<div class="te-tooltip__body te-tooltip__body--large">
+  <div>
+    <span class="te-tooltip__title te-tooltip__title--small">Definition of Terms</span>
+  </div>
+  <p>CV: current value<br/>
+    PV: previous (baseline) value<br/>
+    SUM_CV: total value<br/>
+    SUM_PV: total previous (baseline) value
+  </p>
+  <div>
+    <span class="te-tooltip__title te-tooltip__title--small">Formulas</span>
+  </div>
+  <p>Percentage Change: (CV -PV) * 100 / PV<br/>
+    Change in Contribution: (CV/SUM_CV -PV/ SUM_PV) * 100<br/>
+    Contribution to Overall Change: (CV -PV) * 100 / (SUM_CV-SUM_PV)
 
 Review comment:
   Can you ensure there is a space before & after all the operators?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] xiaohui-sun merged pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…

Posted by GitBox <gi...@apache.org>.
xiaohui-sun merged pull request #5098: [TE] frontend - harleyjj/rca - add tooltip for Dimensions tab to expl…
URL: https://github.com/apache/incubator-pinot/pull/5098
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org