You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2017/09/28 03:09:29 UTC
[GitHub] carbondata pull request #1392: [CARBONDATA-1531] Format module should suppor...
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/1392
[CARBONDATA-1531] Format module should support BOOLEAN
format module support Boolean data type when I was developing Boolean function, and there are some error in CI after push request into github. So format module should support Boolean.
1. add Boolean data type
2. add BOOL_BYTE in Encoding
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata formatSupportBoolean
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1392.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1392
----
commit f1c1462db11701f0d1b1a8b44a41a31d0307fd59
Author: xubo245 <60...@qq.com>
Date: 2017-09-28T03:06:45Z
[CARBONDATA-1531] Format module should support BOOLEAN
----
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1392
LGTM
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1392
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/310/
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1392
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/199/
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1392
Please review and merge it. @jackylk
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1392
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/185/
---
[GitHub] carbondata pull request #1392: [CARBONDATA-1531] Format module should suppor...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1392#discussion_r141580376
--- Diff: format/src/main/thrift/schema.thrift ---
@@ -52,7 +53,8 @@ enum Encoding{
ADAPTIVE_DELTA_INTEGRAL = 8; // Identifies that a column is encoded using AdaptiveDeltaIntegralCodec
RLE_INTEGRAL = 9; // Identifies that a column is encoded using RLECodec
DIRECT_STRING = 10; // Stores string value and string length separately in page data
- ADAPTIVE_FLOATING = 11; // Identifies that a column is encoded using AdaptiveFloatingCodec
+ ADAPTIVE_FLOATING = 11; // Identifies that a column is encoded using AdaptiveFloatingCodec
--- End diff --
correct the indentation
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1392
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/947/
---
[GitHub] carbondata pull request #1392: [CARBONDATA-1531] Format module should suppor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1392
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1392
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/941/
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1392
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/315/
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1392
I have changed indentation @jackylk
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1392
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/951/
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1392
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/323/
---
[GitHub] carbondata issue #1392: [CARBONDATA-1531] Format module should support BOOLE...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1392
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/190/
---