You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/08/14 11:21:32 UTC
[GitHub] [spark] panbingkun opened a new pull request, #42486: [SPARK-44803][BUILD] Replace `publishOrSkip` with `publish` in SparkBuild to eliminate warnings
panbingkun opened a new pull request, #42486:
URL: https://github.com/apache/spark/pull/42486
### What changes were proposed in this pull request?
The pr aims to replace `publishOrSkip` with `publish` in SparkBuild to eliminate warnings.
### Why are the changes needed?
After we upgraded SBT to 1.9.1+, the `publish` method has been marked as deprecated, to reduce compilation warnings.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42486: [SPARK-44803][BUILD] Replace `publishOrSkip` with `publish` in SparkBuild to eliminate warnings
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42486:
URL: https://github.com/apache/spark/pull/42486#issuecomment-1678720195
1.Before
sh build/sbt
<img width="1182" alt="image" src="https://github.com/apache/spark/assets/15246973/5f4c5e2e-6813-46be-9cdb-3f53a02dfb69">
- Maven:
<img width="727" alt="image" src="https://github.com/apache/spark/assets/15246973/275d8c7b-e8db-4c93-b308-85b875360299">
- Ivy:
<img width="631" alt="image" src="https://github.com/apache/spark/assets/15246973/4585a05f-396d-4276-af5d-795922820a33">
2.After
sh build/sbt
<img width="1185" alt="image" src="https://github.com/apache/spark/assets/15246973/ad06b8f9-7155-42e9-80d2-79744312cbcc">
- Maven:
<img width="726" alt="image" src="https://github.com/apache/spark/assets/15246973/2f33c917-ead2-48bd-a07c-ead5cfb2b339">
- Ivy:
<img width="627" alt="image" src="https://github.com/apache/spark/assets/15246973/b4c7dbcd-0f8d-43af-a5cb-f6b9cdd53e26">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42486: [SPARK-44803][BUILD] Replace `publishOrSkip` with `publish` in SparkBuild to eliminate warnings
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42486:
URL: https://github.com/apache/spark/pull/42486#issuecomment-1677147884
We executed the following tests at the code level based on the changes made by SBT.
1.The logic of SBT is as follows:
https://github.com/sbt/sbt/blob/1.9.x/main/src/main/scala/sbt/Defaults.scala#L3642-L3653
2.Test is as follows:
<img width="916" alt="image" src="https://github.com/apache/spark/assets/15246973/1811c570-8a3f-43c7-8fa8-fd786db9ca6c">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42486: [SPARK-44803][BUILD] Replace `publishOrSkip` with `publish` in SparkBuild to eliminate warnings
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42486:
URL: https://github.com/apache/spark/pull/42486#issuecomment-1678805396
cc @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42486: [SPARK-44803][BUILD] Replace `publishOrSkip` with `publish` in SparkBuild to eliminate warnings
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42486:
URL: https://github.com/apache/spark/pull/42486#issuecomment-1677303781
What results should we check and how should we check these results? For example, which commands to use, which result files to observe, could you update this information in the pr description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42486: [SPARK-44803][BUILD] Replace `publish` with `publishOrSkip` in SparkBuild to eliminate warnings
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42486: [SPARK-44803][BUILD] Replace `publish` with `publishOrSkip` in SparkBuild to eliminate warnings
URL: https://github.com/apache/spark/pull/42486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42486: [SPARK-44803][BUILD] Replace `publishOrSkip` with `publish` in SparkBuild to eliminate warnings
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42486:
URL: https://github.com/apache/spark/pull/42486#issuecomment-1677151160
cc @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org