You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "briansolo1985 (via GitHub)" <gi...@apache.org> on 2024/02/20 13:51:18 UTC
[PR] NIFI-12760 Flow sensitive properties encryption support in toolkit [nifi]
briansolo1985 opened a new pull request, #8430:
URL: https://github.com/apache/nifi/pull/8430
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-12760](https://issues.apache.org/jira/browse/NIFI-12760)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [x] Build completed using `mvn clean install -P contrib-check`
- [x] JDK 21
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12760 Flow sensitive properties encryption support in toolkit [nifi]
Posted by "ferencerdei (via GitHub)" <gi...@apache.org>.
ferencerdei closed pull request #8430: NIFI-12760 Flow sensitive properties encryption support in toolkit
URL: https://github.com/apache/nifi/pull/8430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12760 Flow sensitive properties encryption support in toolkit [nifi]
Posted by "ferencerdei (via GitHub)" <gi...@apache.org>.
ferencerdei commented on code in PR #8430:
URL: https://github.com/apache/nifi/pull/8430#discussion_r1504218653
##########
minifi/minifi-toolkit/minifi-toolkit-encrypt-config/src/main/java/org/apache/nifi/minifi/toolkit/config/command/MiNiFiEncryptConfig.java:
##########
@@ -40,54 +53,76 @@
import picocli.CommandLine.Option;
/**
- * Shared Encrypt Configuration for NiFi and NiFi Registry
+ * Encrypt Configuration for MiNiFi
*/
@Command(
- name = "encrypt-config",
- sortOptions = false,
- mixinStandardHelpOptions = true,
- usageHelpWidth = 160,
- separator = " ",
- version = {
- "Java ${java.version} (${java.vendor} ${java.vm.name} ${java.vm.version})"
- },
- descriptionHeading = "Description: ",
- description = {
- "encrypt-config supports protection of sensitive values in Apache MiNiFi"
- }
+ name = "encrypt-config",
+ sortOptions = false,
+ mixinStandardHelpOptions = true,
+ usageHelpWidth = 160,
+ separator = " ",
+ version = {
+ "Java ${java.version} (${java.vendor} ${java.vm.name} ${java.vm.version})"
+ },
+ descriptionHeading = "Description: ",
+ description = {
+ "encrypt-config supports protection of sensitive values in Apache MiNiFi"
+ }
)
-public class MiNiFiEncryptConfig implements Runnable{
+public class MiNiFiEncryptConfig implements Runnable {
static final String BOOTSTRAP_ROOT_KEY_PROPERTY = "minifi.bootstrap.sensitive.key";
private static final String WORKING_FILE_NAME_FORMAT = "%s.%d.working";
private static final int KEY_LENGTH = 32;
@Option(
- names = {"-b", "--bootstrapConf"},
- description = "Path to file containing Bootstrap Configuration [bootstrap.conf] for optional root key and property protection scheme settings"
+ names = {"-b", "--bootstrapConf"},
+ description = "Path to file containing Bootstrap Configuration [bootstrap.conf] for optional root key and property protection scheme settings"
)
Path bootstrapConfPath;
@Option(
- names = {"-B", "--outputBootstrapConf"},
- description = "Path to output file for Bootstrap Configuration [bootstrap.conf] with root key configured"
+ names = {"-B", "--outputBootstrapConf"},
+ description = "Path to output file for Bootstrap Configuration [bootstrap.conf] with root key configured"
)
Path outputBootstrapConf;
+ @Option(
Review Comment:
Could you update the minifi/minifi-toolkit/minifi-toolkit-assembly/README.md with the new flags? An maybe worth to mention that the nifi.minifi.sensitive.props.key, nifi.minifi.sensitive.props.algorithm properties needs to be set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-12760 Flow sensitive properties encryption support in toolkit [nifi]
Posted by "briansolo1985 (via GitHub)" <gi...@apache.org>.
briansolo1985 commented on code in PR #8430:
URL: https://github.com/apache/nifi/pull/8430#discussion_r1506112666
##########
minifi/minifi-toolkit/minifi-toolkit-encrypt-config/src/main/java/org/apache/nifi/minifi/toolkit/config/command/MiNiFiEncryptConfig.java:
##########
@@ -40,54 +53,76 @@
import picocli.CommandLine.Option;
/**
- * Shared Encrypt Configuration for NiFi and NiFi Registry
+ * Encrypt Configuration for MiNiFi
*/
@Command(
- name = "encrypt-config",
- sortOptions = false,
- mixinStandardHelpOptions = true,
- usageHelpWidth = 160,
- separator = " ",
- version = {
- "Java ${java.version} (${java.vendor} ${java.vm.name} ${java.vm.version})"
- },
- descriptionHeading = "Description: ",
- description = {
- "encrypt-config supports protection of sensitive values in Apache MiNiFi"
- }
+ name = "encrypt-config",
+ sortOptions = false,
+ mixinStandardHelpOptions = true,
+ usageHelpWidth = 160,
+ separator = " ",
+ version = {
+ "Java ${java.version} (${java.vendor} ${java.vm.name} ${java.vm.version})"
+ },
+ descriptionHeading = "Description: ",
+ description = {
+ "encrypt-config supports protection of sensitive values in Apache MiNiFi"
+ }
)
-public class MiNiFiEncryptConfig implements Runnable{
+public class MiNiFiEncryptConfig implements Runnable {
static final String BOOTSTRAP_ROOT_KEY_PROPERTY = "minifi.bootstrap.sensitive.key";
private static final String WORKING_FILE_NAME_FORMAT = "%s.%d.working";
private static final int KEY_LENGTH = 32;
@Option(
- names = {"-b", "--bootstrapConf"},
- description = "Path to file containing Bootstrap Configuration [bootstrap.conf] for optional root key and property protection scheme settings"
+ names = {"-b", "--bootstrapConf"},
+ description = "Path to file containing Bootstrap Configuration [bootstrap.conf] for optional root key and property protection scheme settings"
)
Path bootstrapConfPath;
@Option(
- names = {"-B", "--outputBootstrapConf"},
- description = "Path to output file for Bootstrap Configuration [bootstrap.conf] with root key configured"
+ names = {"-B", "--outputBootstrapConf"},
+ description = "Path to output file for Bootstrap Configuration [bootstrap.conf] with root key configured"
)
Path outputBootstrapConf;
+ @Option(
Review Comment:
Sure, added the instructions to the guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org