[GitHub] [incubator-yunikorn-k8shim] TaoYang526 commented on issue #84: [YUNIKORN-36] Cleanup leaked resources when deleting the helm chart

[GitBox <gi...@apache.org>]

TaoYang526 commented on issue #84: [YUNIKORN-36] Cleanup leaked resources when deleting the helm chart
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/84#issuecomment-603709071
 
 
   Thanks @wilfred-s , @yangwwei  for the review.
   > Can we leverage the yunikorn scheduler docker image which already has the script installed, we can do `admission_util.sh delete ` to clean up everything
   
   I think we can't do that since the command will be called in PreStop hook which is called immediately before a container is terminated due to an API request or management event such as liveness probe failure, preemption, resource contention and others, not just before the final termination. (Please refer to https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#container-hooks)
   
   I haven't find a proper image to replace deprecated hyperkube image after a quick search, I'll find another image or another way to solve this problem. Please share your thoughts if you have any idea about this. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org